Skip to content
Permalink
Browse files
2011-03-05 Andrey Kosyakov <caseq@chromium.org>
        Reviewed by Pavel Feldman.

        Web Inspector: inspector/extensions/extensions-events.html sometimes fails on Windows
        https://bugs.webkit.org/show_bug.cgi?id=54974

        Properly serialize test output to fix flakiness due to race with output during page reload.

        * inspector/extensions/extensions-events-expected.txt:
        * inspector/extensions/extensions-events.html:
        * platform/win/Skipped:


Canonical link: https://commits.webkit.org/70315@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@80421 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
caseq committed Mar 5, 2011
1 parent 411d340 commit c251fccca0c3e289ba18bb8fcedd537e50661f03
Showing with 28 additions and 10 deletions.
  1. +13 −0 LayoutTests/ChangeLog
  2. +15 −7 LayoutTests/inspector/extensions/extensions-events.html
  3. +0 −3 LayoutTests/platform/win/Skipped
@@ -1,3 +1,16 @@
2011-03-05 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: inspector/extensions/extensions-events.html sometimes fails on Windows
https://bugs.webkit.org/show_bug.cgi?id=54974

Properly serialize test output to fix flakiness due to race with output during page reload.

* inspector/extensions/extensions-events-expected.txt:
* inspector/extensions/extensions-events.html:
* platform/win/Skipped:

2011-03-05 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.
@@ -34,18 +34,26 @@
function extension_testPageLoadEvents(nextTest)
{
var callbackCount = 0;
var onLoadArgument;

webInspector.inspectedWindow.onDOMContentLoaded.addListener(function(time) {
output("onDOMContentLoaded fired: " + typeof time);
});

// Logging on onLoaded is tricky due to race conditions with output("Page reloaded") in page initialization code.
// So only log when we're sure both onLoaded fired and reload is done.
function reloadCallback()
{
if (++callbackCount < 2)
return;
output("onLoaded fired: " + typeof onLoadArgument);
nextTest();
}
webInspector.inspectedWindow.onLoaded.addListener(function(time) {
output("onLoaded fired: " + typeof time);
if (++callbackCount > 1)
nextTest();
});
dispatchOnFrontend({ command: "reload" }, function() {
if (++callbackCount > 1)
nextTest();
onLoadArgument = time;
reloadCallback();
});
dispatchOnFrontend({ command: "reload" }, reloadCallback);
}

</script>
@@ -410,9 +410,6 @@ http/tests/security/xssAuditor/script-tag-with-fancy-unicode.html
# Needs windows-specific pixel results http://webkit.org/b/54757
media/video-controls-in-media-document.html

# Sometimes fails http://webkit.org/b/54974
inspector/extensions/extensions-events.html

# Sometimes crashes http://webkit.org/b/55375
http/tests/websocket/tests/reload-crash.html

0 comments on commit c251fcc

Please sign in to comment.