Skip to content
Permalink
Browse files
-Wmismatched-new-delete warning spam from CSSStyleValue.h
https://bugs.webkit.org/show_bug.cgi?id=241516

Patch by Michael Catanzaro <mcatanzaro@redhat.com> on 2022-06-21
Reviewed by Chris Dumez.

I cannot find any reason behind this warning. Mismatched new/delete is
very serious if true, but in this case, I just do not see it. If we are
doing something wrong, it must be somehow related to the iso heap, but
don't think we are.

* Source/WebCore/css/typedom/CSSStyleValue.h:

Canonical link: https://commits.webkit.org/251697@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@295692 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
mcatanzaro authored and webkit-commit-queue committed Jun 21, 2022
1 parent 305e43b commit c337b98196beb3fed3f1ed0f615e606f26b0370a
Showing 1 changed file with 4 additions and 0 deletions.
@@ -110,7 +110,11 @@ class CSSStyleValue : public RefCounted<CSSStyleValue>, public ScriptWrappable {
public:
String toString() const;
virtual void serialize(StringBuilder&, OptionSet<SerializationArguments> = { }) const;

IGNORE_GCC_WARNINGS_BEGIN("mismatched-new-delete")
// https://webkit.org/b/241516
virtual ~CSSStyleValue() = default;
IGNORE_GCC_WARNINGS_END

virtual CSSStyleValueType getType() const { return CSSStyleValueType::CSSStyleValue; }

0 comments on commit c337b98

Please sign in to comment.