Skip to content
Permalink
Browse files
Source/WebCore: Unreviewed rollout r107952 because it broke shadow-bo…
…undary-events.html and related-target-focusevent.html on mac.

see http://webkit.org/b/78832

* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* dom/DOMAllInOne.cpp:
* dom/EventDispatchMediator.cpp:
(WebCore::FocusEventDispatchMediator::create):
(WebCore):
(WebCore::FocusEventDispatchMediator::FocusEventDispatchMediator):
(WebCore::FocusEventDispatchMediator::dispatchEvent):
(WebCore::BlurEventDispatchMediator::create):
(WebCore::BlurEventDispatchMediator::BlurEventDispatchMediator):
(WebCore::BlurEventDispatchMediator::dispatchEvent):
* dom/EventDispatchMediator.h:
(FocusEventDispatchMediator):
(WebCore):
(BlurEventDispatchMediator):
* dom/EventFactory.in:
* dom/FocusEvent.cpp: Removed.
* dom/FocusEvent.h: Removed.
* dom/FocusEvent.idl: Removed.
* dom/Node.cpp:
(WebCore::Node::dispatchFocusInEvent):
(WebCore::Node::dispatchFocusOutEvent):
* dom/UIEvent.cpp:
(WebCore::FocusInEventDispatchMediator::create):
(WebCore):
(WebCore::FocusInEventDispatchMediator::FocusInEventDispatchMediator):
(WebCore::FocusInEventDispatchMediator::dispatchEvent):
(WebCore::FocusOutEventDispatchMediator::create):
(WebCore::FocusOutEventDispatchMediator::FocusOutEventDispatchMediator):
(WebCore::FocusOutEventDispatchMediator::dispatchEvent):
* dom/UIEvent.h:
(FocusInEventDispatchMediator):
(WebCore):
(FocusOutEventDispatchMediator):
* page/DOMWindow.idl:

LayoutTests: Unreviewed rollout r107952 because it broke shadow-boundary-events.html and related-target-focusevent.html on mac.
see http://webkit.org/b/78832

* fast/dom/shadow/shadow-boundary-events-expected.txt:
* fast/dom/shadow/shadow-boundary-events.html:
* fast/events/event-creation-expected.txt:
* fast/events/event-creation.html:
* fast/events/related-target-focusevent-expected.txt: Removed.
* fast/events/related-target-focusevent.html: Removed.

Canonical link: https://commits.webkit.org/95868@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108034 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
loislo committed Feb 17, 2012
1 parent 77bf7fd commit c3639fefe274159172c230a5d060ebffd4fb4c76
@@ -1,3 +1,15 @@
2012-02-16 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed rollout r107952 because it broke shadow-boundary-events.html and related-target-focusevent.html on mac.
see http://webkit.org/b/78832

* fast/dom/shadow/shadow-boundary-events-expected.txt:
* fast/dom/shadow/shadow-boundary-events.html:
* fast/events/event-creation-expected.txt:
* fast/events/event-creation.html:
* fast/events/related-target-focusevent-expected.txt: Removed.
* fast/events/related-target-focusevent.html: Removed.

2012-02-16 Noel Gordon <noel.gordon@gmail.com>
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454
@@ -61,13 +61,13 @@ PASS dispatchedEvent("mouseout") is ["divH(<-shadowK)(@divH)", "shadowG(<-shadow

Move focus from a node to its sibling node. All nodes are outside of shadow boundary.
Moving focus from divB to divC
PASS dispatchedEvent("focusin") is ["divC(<-divB)(@divC)", "divC(<-divB)(@divA)"]
PASS dispatchedEvent("focusout") is ["divB(<-divC)(@divB)", "divB(<-divC)(@divA)"]
PASS dispatchedEvent("focusin") is ["divC(@divC)", "divC(@divA)"]
PASS dispatchedEvent("focusout") is ["divB(@divB)", "divB(@divA)"]

Old focused node and new focused node exist in separated subtrees, crossing shadow boundaries. Making sure that an event is not dispatched beyond the lowest common boundary.
Moving focus from shadowD/shadowF/shadowG/divH to shadowD/shadowK/divL
PASS dispatchedEvent("focusin") is ["divL(<-shadowF)(@divL)", "shadowK(<-shadowF)(@shadowK)", "shadowK(<-shadowF)(@divJ)"]
PASS dispatchedEvent("focusout") is ["divH(<-shadowK)(@divH)", "shadowG(<-shadowK)(@shadowG)", "shadowF(<-shadowK)(@shadowF)", "shadowF(<-shadowK)(@divE)"]
PASS dispatchedEvent("focusin") is ["divL(@divL)", "shadowK(@shadowK)", "shadowK(@divJ)"]
PASS dispatchedEvent("focusout") is ["divH(@divH)", "shadowG(@shadowG)", "shadowF(@shadowF)", "shadowF(@divE)"]

Move focus from a node to its sibling node. All nodes are outside of shadow boundary.
Moving focus from divB to divC
@@ -187,13 +187,13 @@
// Test for focusin/focusout events.
moveFocus('divB', 'divC',
'Move focus from a node to its sibling node. All nodes are outside of shadow boundary.');
shouldBe('dispatchedEvent("focusin")', '["divC(<-divB)(@divC)", "divC(<-divB)(@divA)"]');
shouldBe('dispatchedEvent("focusout")', '["divB(<-divC)(@divB)", "divB(<-divC)(@divA)"]');
shouldBe('dispatchedEvent("focusin")', '["divC(@divC)", "divC(@divA)"]');
shouldBe('dispatchedEvent("focusout")', '["divB(@divB)", "divB(@divA)"]');

moveFocus('shadowD/shadowF/shadowG/divH', 'shadowD/shadowK/divL',
'Old focused node and new focused node exist in separated subtrees, crossing shadow boundaries. Making sure that an event is not dispatched beyond the lowest common boundary.');
shouldBe('dispatchedEvent("focusin")', '["divL(<-shadowF)(@divL)", "shadowK(<-shadowF)(@shadowK)", "shadowK(<-shadowF)(@divJ)"]');
shouldBe('dispatchedEvent("focusout")', '["divH(<-shadowK)(@divH)", "shadowG(<-shadowK)(@shadowG)", "shadowF(<-shadowK)(@shadowF)", "shadowF(<-shadowK)(@divE)"]');
shouldBe('dispatchedEvent("focusin")', '["divL(@divL)", "shadowK(@shadowK)", "shadowK(@divJ)"]');
shouldBe('dispatchedEvent("focusout")', '["divH(@divH)", "shadowG(@shadowG)", "shadowF(@shadowF)", "shadowF(@divE)"]');

// Omitted test cases where either a oldFocusedNode or newFocusedNode is an ancestor of the other.
// Due to a focus transfer mechanism on shadow hosts, a focused node should be a leaf node in general.
@@ -21,10 +21,6 @@ PASS document.createEvent('CustomEvent').constructor === window.CustomEvent is t
PASS document.createEvent('ErrorEvent') instanceof window.ErrorEvent is true
PASS document.createEvent('ErrorEvent') instanceof window.Event is true
PASS document.createEvent('ErrorEvent').constructor === window.ErrorEvent is true
PASS document.createEvent('FocusEvent') instanceof window.FocusEvent is true
PASS document.createEvent('FocusEvent') instanceof window.UIEvent is true
PASS document.createEvent('FocusEvent') instanceof window.Event is true
PASS document.createEvent('FocusEvent').constructor === window.FocusEvent is true
PASS document.createEvent('HashChangeEvent') instanceof window.HashChangeEvent is true
PASS document.createEvent('HashChangeEvent') instanceof window.Event is true
PASS document.createEvent('HashChangeEvent').constructor === window.HashChangeEvent is true
@@ -37,12 +37,6 @@
shouldBeTrue("document.createEvent('ErrorEvent') instanceof window.Event");
shouldBeTrue("document.createEvent('ErrorEvent').constructor === window.ErrorEvent");

// FocusEvent
shouldBeTrue("document.createEvent('FocusEvent') instanceof window.FocusEvent");
shouldBeTrue("document.createEvent('FocusEvent') instanceof window.UIEvent");
shouldBeTrue("document.createEvent('FocusEvent') instanceof window.Event");
shouldBeTrue("document.createEvent('FocusEvent').constructor === window.FocusEvent");

// HashChangeEvent
shouldBeTrue("document.createEvent('HashChangeEvent') instanceof window.HashChangeEvent");
shouldBeTrue("document.createEvent('HashChangeEvent') instanceof window.Event");

This file was deleted.

This file was deleted.

@@ -158,7 +158,6 @@ SET(WebCore_IDL_FILES
dom/ErrorEvent.idl
dom/EventException.idl
dom/Event.idl
dom/FocusEvent.idl
dom/HashChangeEvent.idl
dom/KeyboardEvent.idl
dom/MessageChannel.idl
@@ -559,7 +558,6 @@ SET(WebCore_SOURCES
dom/EventTarget.cpp
dom/ExceptionBase.cpp
dom/ExceptionCodePlaceholder.cpp
dom/FocusEvent.cpp
dom/GenericEventQueue.cpp
dom/IconURL.cpp
dom/KeyboardEvent.cpp
@@ -1,3 +1,50 @@
2012-02-16 Ilya Tikhonovsky <loislo@chromium.org>

Unreviewed rollout r107952 because it broke shadow-boundary-events.html and related-target-focusevent.html on mac.
see http://webkit.org/b/78832

* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* dom/DOMAllInOne.cpp:
* dom/EventDispatchMediator.cpp:
(WebCore::FocusEventDispatchMediator::create):
(WebCore):
(WebCore::FocusEventDispatchMediator::FocusEventDispatchMediator):
(WebCore::FocusEventDispatchMediator::dispatchEvent):
(WebCore::BlurEventDispatchMediator::create):
(WebCore::BlurEventDispatchMediator::BlurEventDispatchMediator):
(WebCore::BlurEventDispatchMediator::dispatchEvent):
* dom/EventDispatchMediator.h:
(FocusEventDispatchMediator):
(WebCore):
(BlurEventDispatchMediator):
* dom/EventFactory.in:
* dom/FocusEvent.cpp: Removed.
* dom/FocusEvent.h: Removed.
* dom/FocusEvent.idl: Removed.
* dom/Node.cpp:
(WebCore::Node::dispatchFocusInEvent):
(WebCore::Node::dispatchFocusOutEvent):
* dom/UIEvent.cpp:
(WebCore::FocusInEventDispatchMediator::create):
(WebCore):
(WebCore::FocusInEventDispatchMediator::FocusInEventDispatchMediator):
(WebCore::FocusInEventDispatchMediator::dispatchEvent):
(WebCore::FocusOutEventDispatchMediator::create):
(WebCore::FocusOutEventDispatchMediator::FocusOutEventDispatchMediator):
(WebCore::FocusOutEventDispatchMediator::dispatchEvent):
* dom/UIEvent.h:
(FocusInEventDispatchMediator):
(WebCore):
(FocusOutEventDispatchMediator):
* page/DOMWindow.idl:

2012-02-16 Mark Hahnenberg <mhahnenberg@apple.com>

Another fix for viewport tests
@@ -129,7 +129,6 @@
#include "JSFileWriterSync.cpp"
#include "JSFloat32Array.cpp"
#include "JSFloat64Array.cpp"
#include "JSFocusEvent.cpp"
#include "JSGeolocation.cpp"
#include "JSGeoposition.cpp"
#include "JSHashChangeEvent.cpp"
@@ -111,7 +111,6 @@ BINDING_IDLS = \
$(WebCore)/dom/EventException.idl \
$(WebCore)/dom/EventListener.idl \
$(WebCore)/dom/EventTarget.idl \
$(WebCore)/dom/FocusEvent.idl \
$(WebCore)/dom/HashChangeEvent.idl \
$(WebCore)/dom/KeyboardEvent.idl \
$(WebCore)/dom/MessageChannel.idl \
@@ -142,7 +142,6 @@ IDL_BINDINGS += \
$$PWD/dom/EventException.idl \
# $$PWD/dom/EventListener.idl \
# $$PWD/dom/EventTarget.idl \
$$PWD/dom/FocusEvent.idl \
$$PWD/dom/HashChangeEvent.idl \
$$PWD/dom/KeyboardEvent.idl \
$$PWD/dom/MouseEvent.idl \
@@ -183,8 +183,6 @@ webcore_built_sources += \
DerivedSources/WebCore/JSFloat32Array.h \
DerivedSources/WebCore/JSFloat64Array.cpp \
DerivedSources/WebCore/JSFloat64Array.h \
DerivedSources/WebCore/JSFocusEvent.cpp \
DerivedSources/WebCore/JSFocusEvent.h \
DerivedSources/WebCore/JSGeolocation.cpp \
DerivedSources/WebCore/JSGeolocation.h \
DerivedSources/WebCore/JSGeoposition.cpp \
@@ -705,7 +703,6 @@ dom_binding_idls += \
$(WebCore)/dom/ErrorEvent.idl \
$(WebCore)/dom/Event.idl \
$(WebCore)/dom/EventException.idl \
$(WebCore)/dom/FocusEvent.idl \
$(WebCore)/dom/HashChangeEvent.idl \
$(WebCore)/dom/KeyboardEvent.idl \
$(WebCore)/dom/MessageChannel.idl \
@@ -1572,8 +1569,6 @@ webcore_sources += \
Source/WebCore/dom/ExceptionCode.h \
Source/WebCore/dom/ExceptionCodePlaceholder.cpp \
Source/WebCore/dom/ExceptionCodePlaceholder.h \
Source/WebCore/dom/FocusEvent.cpp \
Source/WebCore/dom/FocusEvent.h \
Source/WebCore/dom/FragmentScriptingPermission.h \
Source/WebCore/dom/IgnoreDestructiveWriteCountIncrementer.h \
Source/WebCore/dom/ExceptionCodePlaceholder.h \
@@ -521,7 +521,6 @@ SOURCES += \
dom/EventTarget.cpp \
dom/ExceptionBase.cpp \
dom/ExceptionCodePlaceholder.cpp \
dom/FocusEvent.cpp \
dom/GenericEventQueue.cpp \
dom/IconURL.cpp \
dom/KeyboardEvent.cpp \
@@ -1636,7 +1635,6 @@ HEADERS += \
dom/EventTarget.h \
dom/ExceptionBase.h \
dom/ExceptionCode.h \
dom/FocusEvent.h \
dom/FragmentScriptingPermission.h \
dom/KeyboardEvent.h \
dom/MessageChannel.h \
@@ -600,7 +600,6 @@
'dom/EventTarget.h',
'dom/ExceptionCode.h',
'dom/ExceptionCodePlaceholder.h',
'dom/FocusEvent.h',
'dom/FragmentScriptingPermission.h',
'dom/KeyboardEvent.h',
'dom/MessagePort.h',
@@ -626,7 +625,6 @@
'dom/Text.h',
'dom/TextEventInputType.h',
'dom/UIEvent.h',
'dom/FocusEvent.h',
'dom/UIEventWithKeyState.h',
'dom/UserGestureIndicator.h',
'dom/UserTypingGestureIndicator.h',
@@ -786,7 +784,6 @@
'dom/EventException.idl',
'dom/EventListener.idl',
'dom/EventTarget.idl',
'dom/FocusEvent.idl',
'dom/HashChangeEvent.idl',
'dom/KeyboardEvent.idl',
'dom/MessageChannel.idl',
@@ -819,7 +816,6 @@
'dom/TouchList.idl',
'dom/TreeWalker.idl',
'dom/UIEvent.idl',
'dom/FocusEvent.idl',
'dom/WebKitAnimationEvent.idl',
'dom/WebKitMutationObserver.idl',
'dom/WebKitNamedFlow.idl',
@@ -5031,7 +5027,6 @@
'dom/ExceptionBase.cpp',
'dom/ExceptionBase.h',
'dom/ExceptionCodePlaceholder.cpp',
'dom/FocusEvent.cpp',
'dom/GenericEventQueue.cpp',
'dom/GenericEventQueue.h',
'dom/HashChangeEvent.h',
@@ -5148,7 +5143,6 @@
'dom/TreeWalker.cpp',
'dom/TreeWalker.h',
'dom/UIEvent.cpp',
'dom/FocusEvent.cpp',
'dom/UIEventWithKeyState.cpp',
'dom/UserGestureIndicator.cpp',
'dom/UserTypingGestureIndicator.cpp',
@@ -7162,8 +7156,6 @@
'<(PRODUCT_DIR)/DerivedSources/WebCore/JSFileWriterSync.h',
'<(PRODUCT_DIR)/DerivedSources/WebCore/JSFloat32Array.cpp',
'<(PRODUCT_DIR)/DerivedSources/WebCore/JSFloat32Array.h',
'<(PRODUCT_DIR)/DerivedSources/WebCore/JSFocusEvent.cpp',
'<(PRODUCT_DIR)/DerivedSources/WebCore/JSFocusEvent.h',
'<(PRODUCT_DIR)/DerivedSources/WebCore/JSGeolocation.cpp',
'<(PRODUCT_DIR)/DerivedSources/WebCore/JSGeolocation.h',
'<(PRODUCT_DIR)/DerivedSources/WebCore/JSGeoposition.cpp',

0 comments on commit c3639fe

Please sign in to comment.