Skip to content
Permalink
Browse files
2011-04-28 Dominic Cooney <dominicc@chromium.org>
        Reviewed by Geoffrey Garen.

        Walk shadow hosts as well as parent nodes when finding opaque roots.
        https://bugs.webkit.org/show_bug.cgi?id=59571

        Remove expectation of failure.

        * platform/mac/fast/dom/shadow/gc-shadow-expected.txt: Removed.
2011-04-28  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Geoffrey Garen.

        Walk shadow hosts as well as parent nodes when finding opaque roots.
        https://bugs.webkit.org/show_bug.cgi?id=59571

        Test: fast/dom/shadow/gc-shadow.html

        * bindings/js/JSDOMBinding.h:
        (WebCore::root):

Canonical link: https://commits.webkit.org/74927@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@85216 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
dglazkov committed Apr 28, 2011
1 parent 1ea4807 commit c43dc9c0617ce4024ec842d150956e56c089676d
Showing with 25 additions and 19 deletions.
  1. +11 −0 LayoutTests/ChangeLog
  2. +0 −17 LayoutTests/platform/mac/fast/dom/shadow/gc-shadow-expected.txt
  3. +12 −0 Source/WebCore/ChangeLog
  4. +2 −2 Source/WebCore/bindings/js/JSDOMBinding.h
@@ -1,3 +1,14 @@
2011-04-28 Dominic Cooney <dominicc@chromium.org>

Reviewed by Geoffrey Garen.

Walk shadow hosts as well as parent nodes when finding opaque roots.
https://bugs.webkit.org/show_bug.cgi?id=59571

Remove expectation of failure.

* platform/mac/fast/dom/shadow/gc-shadow-expected.txt: Removed.

2011-04-28 Dimitri Glazkov <dglazkov@chromium.org>

Added the test results, missed in r85209.

This file was deleted.

@@ -1,3 +1,15 @@
2011-04-28 Dominic Cooney <dominicc@chromium.org>

Reviewed by Geoffrey Garen.

Walk shadow hosts as well as parent nodes when finding opaque roots.
https://bugs.webkit.org/show_bug.cgi?id=59571

Test: fast/dom/shadow/gc-shadow.html

* bindings/js/JSDOMBinding.h:
(WebCore::root):

2011-04-28 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.
@@ -171,8 +171,8 @@ namespace WebCore {
if (node->inDocument())
return node->document();

while (node->parentNode())
node = node->parentNode();
while (node->parentOrHostNode())
node = node->parentOrHostNode();
return node;
}

0 comments on commit c43dc9c

Please sign in to comment.