Unreviewed, GStreamer follow-up after r276493

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin): Remove spurious adoptGRef call, as this is not transfer-full. Canonical link: https://commits.webkit.org/236954@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@276495 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebKit · Apr 23, 2021 · c5eb83d · c5eb83d
1 parent b63da47
commit c5eb83d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
@@ -1,3 +1,11 @@
+2021-04-23  Philippe Normand  <pnormand@igalia.com>
+
+        Unreviewed, GStreamer follow-up after r276493
+
+        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+        (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin): Remove spurious adoptGRef call, as
+        this is not transfer-full.
+
 2021-04-23  Philippe Normand  <pnormand@igalia.com>
 
         [Media] Allow access to MediaElement id from MediaPlayerPrivate

diff --git a/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp b/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
@@ -2700,7 +2700,7 @@ void MediaPlayerPrivateGStreamer::createGSTPlayBin(const URL& url)
 
     static Atomic<uint32_t> pipelineId;
 
-    m_pipeline = adoptGRef(gst_element_factory_make(playbinName, makeString(type, elementId, '-', pipelineId.exchangeAdd(1)).ascii().data()));
+    m_pipeline = gst_element_factory_make(playbinName, makeString(type, elementId, '-', pipelineId.exchangeAdd(1)).ascii().data());
     if (!m_pipeline) {
         GST_WARNING("%s not found, make sure to install gst-plugins-base", playbinName);
         loadingFailed(MediaPlayer::NetworkState::FormatError, MediaPlayer::ReadyState::HaveNothing, true);