Skip to content
Permalink
Browse files
Fixed compilation of PluginView when NETSCAPE_PLUGIN_API is disabled
https://bugs.webkit.org/show_bug.cgi?id=162725

Reviewed by Alex Christensen.

Fix for r206460, streamDidFinishLoading() does not override anything
when NETSCAPE_PLUGIN_API is disabled because PlugivView does not
inherit PluginStreamClient in this case.

* Plugins/PluginView.h:


Canonical link: https://commits.webkit.org/180669@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@206586 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
annulen committed Sep 29, 2016
1 parent 40d7eae commit c6a236062e2eab7942aa4b681f947f68b79dd938
Showing 2 changed files with 15 additions and 0 deletions.
@@ -1,3 +1,16 @@
2016-09-29 Konstantin Tokarev <annulen@yandex.ru>

Fixed compilation of PluginView when NETSCAPE_PLUGIN_API is disabled
https://bugs.webkit.org/show_bug.cgi?id=162725

Reviewed by Alex Christensen.

Fix for r206460, streamDidFinishLoading() does not override anything
when NETSCAPE_PLUGIN_API is disabled because PlugivView does not
inherit PluginStreamClient in this case.

* Plugins/PluginView.h:

2016-09-27 Konstantin Tokarev <annulen@yandex.ru>

Use override specifiers in PluginView
@@ -170,7 +170,9 @@ namespace WebCore {
void privateBrowsingStateChanged(bool) override;

void disconnectStream(PluginStream*);
#if ENABLE(NETSCAPE_PLUGIN_API)
void streamDidFinishLoading(PluginStream* stream) override { disconnectStream(stream); }
#endif

// Widget functions
void setFrameRect(const IntRect&) override;

0 comments on commit c6a2360

Please sign in to comment.