Skip to content
Permalink
Browse files
Unreviewed, rolling out r245058.
Causes crashes under ASan / GuardMalloc

Reverted changeset:

"Implement backing-sharing in compositing layers, allowing
overlap layers to paint into the backing store of another
layer"
https://bugs.webkit.org/show_bug.cgi?id=197561
https://trac.webkit.org/changeset/245058

Canonical link: https://commits.webkit.org/211864@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@245085 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
ryanhaddad committed May 9, 2019
1 parent be064f5 commit c6f27b14cf6820b40de9bd53397342f580dd9563
Show file tree
Hide file tree
Showing 79 changed files with 446 additions and 2,671 deletions.
@@ -1,3 +1,17 @@
2019-05-08 Ryan Haddad <ryanhaddad@apple.com>

Unreviewed, rolling out r245058.

Causes crashes under ASan / GuardMalloc

Reverted changeset:

"Implement backing-sharing in compositing layers, allowing
overlap layers to paint into the backing store of another
layer"
https://bugs.webkit.org/show_bug.cgi?id=197561
https://trac.webkit.org/changeset/245058

2019-05-08 Tim Horton <timothy_horton@apple.com>

Unreviewed test rebaselines.
@@ -59,9 +59,6 @@ editing/pasteboard/ios [ Skip ]
editing/pasteboard/mac [ Skip ]
fast/media/ios [ Skip ]

# Requires async overflow scrolling
compositing/shared-backing/overflow-scroll [ Skip ]

# WebKit2 only.
printing/printing-events.html [ Skip ]

@@ -11,7 +11,7 @@ middlebottom
(GraphicsLayer
(bounds 785.00 2618.00)
(contentsOpaque 1)
(children 3
(children 6
(GraphicsLayer
(position 21.00 21.00)
(bounds 100.00 100.00)
@@ -21,14 +21,52 @@ middlebottom
(bounds 220.00 220.00)
(drawsContent 1)
)
(GraphicsLayer
(offsetFromRenderer width=0 height=100)
(position 28.00 20.00)
(bounds 200.00 200.00)
(children 1
(GraphicsLayer
(offsetFromRenderer width=0 height=100)
(bounds 110.00 200.00)
(contentsOpaque 1)
(drawsContent 1)
)
)
)
(GraphicsLayer
(offsetFromRenderer width=-5 height=-145)
(position 28.00 20.00)
(bounds 200.00 200.00)
(children 1
(GraphicsLayer
(position 5.00 145.00)
(bounds 144.00 24.00)
(drawsContent 1)
)
)
)
(GraphicsLayer
(offsetFromRenderer width=0 height=100)
(position 28.00 250.00)
(bounds 185.00 200.00)
(children 1
(GraphicsLayer
(offsetFromRenderer width=0 height=100)
(bounds 149.00 200.00)
(bounds 110.00 200.00)
(contentsOpaque 1)
(drawsContent 1)
)
)
)
(GraphicsLayer
(offsetFromRenderer width=-5 height=-145)
(position 28.00 250.00)
(bounds 185.00 200.00)
(children 1
(GraphicsLayer
(position 5.00 145.00)
(bounds 144.00 24.00)
(drawsContent 1)
)
)
@@ -5,7 +5,7 @@
(GraphicsLayer
(bounds 800.00 600.00)
(contentsOpaque 1)
(children 2
(children 3
(GraphicsLayer
(position 8.00 8.00)
(bounds 30.00 30.00)
@@ -15,6 +15,18 @@
(bounds 306.00 206.00)
(drawsContent 1)
)
(GraphicsLayer
(offsetFromRenderer width=-20 height=-45)
(position 23.00 23.00)
(bounds 285.00 200.00)
(children 1
(GraphicsLayer
(position 20.00 45.00)
(bounds 210.00 100.00)
(contentsOpaque 1)
)
)
)
)
)
)
@@ -52,7 +52,7 @@
document.getElementById('results').innerText = window.internals.layerTreeAsText(document);
testRunner.notifyDone();
}
}, 0);
}, 150);
}

window.addEventListener('load', doTest, false);
@@ -23,7 +23,7 @@
height: 1200px;
background: silver;
border: 2px solid blue;
transform: translateZ(0);
z-index: 0;
}
</style>
<script>
@@ -6,7 +6,7 @@
(GraphicsLayer
(bounds 800.00 600.00)
(contentsOpaque 1)
(children 3
(children 4
(GraphicsLayer
(position 8.00 8.00)
(bounds 404.00 223.00)
@@ -29,6 +29,18 @@
)
)
)
(GraphicsLayer
(offsetFromRenderer width=-250 height=0)
(position 10.00 10.00)
(bounds 400.00 204.00)
(children 1
(GraphicsLayer
(position 250.00 0.00)
(bounds 150.00 200.00)
(contentsOpaque 1)
)
)
)
(GraphicsLayer
(offsetFromRenderer width=-96 height=0)
(position 10.00 10.00)

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

0 comments on commit c6f27b1

Please sign in to comment.