Skip to content
Permalink
Browse files
Unreviewed, rolling out r223321.
https://bugs.webkit.org/show_bug.cgi?id=178476

This protocol change broke some internal builds (Requested by
brrian__ on #webkit).

Reverted changeset:

"Web Inspector: provide a way to enable/disable event
listeners"
https://bugs.webkit.org/show_bug.cgi?id=177451
https://trac.webkit.org/changeset/223321

Canonical link: https://commits.webkit.org/194671@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@223618 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
webkit-commit-queue committed Oct 18, 2017
1 parent d923f7c commit c7ea392aaf9a3e564edf67d2efbeaff29ca0928a
@@ -1,3 +1,18 @@
2017-10-18 Commit Queue <commit-queue@webkit.org>

Unreviewed, rolling out r223321.
https://bugs.webkit.org/show_bug.cgi?id=178476

This protocol change broke some internal builds (Requested by
brrian__ on #webkit).

Reverted changeset:

"Web Inspector: provide a way to enable/disable event
listeners"
https://bugs.webkit.org/show_bug.cgi?id=177451
https://trac.webkit.org/changeset/223321

2017-10-18 Alex Christensen <achristensen@webkit.org>

http/tests/loading/basic-auth-resend-wrong-credentials.html is still a flaky failure after proposed fix.

This file was deleted.

This file was deleted.

@@ -1,3 +1,18 @@
2017-10-18 Commit Queue <commit-queue@webkit.org>

Unreviewed, rolling out r223321.
https://bugs.webkit.org/show_bug.cgi?id=178476

This protocol change broke some internal builds (Requested by
brrian__ on #webkit).

Reverted changeset:

"Web Inspector: provide a way to enable/disable event
listeners"
https://bugs.webkit.org/show_bug.cgi?id=177451
https://trac.webkit.org/changeset/223321

2017-10-18 Mark Lam <mark.lam@apple.com>

The compiler should always register a structure when it adds its transitionWatchPointSet.
@@ -13,11 +13,6 @@
"type": "integer",
"description": "Unique DOM node identifier used to reference a node that may not have been pushed to the front-end."
},
{
"id": "EventListenerId",
"type": "integer",
"description": "Unique event listener identifier."
},
{
"id": "PseudoType",
"type": "string",
@@ -79,7 +74,6 @@
"type": "object",
"description": "A structure holding event listener properties.",
"properties": [
{ "name": "eventListenerId", "$ref": "EventListenerId" },
{ "name": "type", "type": "string", "description": "<code>EventListener</code>'s type." },
{ "name": "useCapture", "type": "boolean", "description": "<code>EventListener</code>'s useCapture." },
{ "name": "isAttribute", "type": "boolean", "description": "<code>EventListener</code>'s isAttribute." },
@@ -89,8 +83,7 @@
{ "name": "sourceName", "type": "string", "optional": true, "description": "Source script URL." },
{ "name": "handler", "$ref": "Runtime.RemoteObject", "optional": true, "description": "Event handler function value." },
{ "name": "passive", "type": "boolean", "optional": true, "description": "<code>EventListener</code>'s passive." },
{ "name": "once", "type": "boolean", "optional": true, "description": "<code>EventListener</code>'s once." },
{ "name": "disabled", "type": "boolean", "optional": true }
{ "name": "once", "type": "boolean", "optional": true, "description": "<code>EventListener</code>'s once." }
]
},
{
@@ -265,14 +258,6 @@
{ "name": "listeners", "type": "array", "items": { "$ref": "EventListener"}, "description": "Array of relevant listeners." }
]
},
{
"name": "setEventListenerDisabled",
"description": "Enable/disable the given event listener. A disabled event listener will not fire.",
"parameters": [
{ "name": "eventListenerId", "$ref": "EventListenerId" },
{ "name": "disabled", "type": "boolean" }
]
},
{
"name": "getAccessibilityPropertiesForNode",
"description": "Returns a dictionary of accessibility properties for the node.",
@@ -1,3 +1,18 @@
2017-10-18 Commit Queue <commit-queue@webkit.org>

Unreviewed, rolling out r223321.
https://bugs.webkit.org/show_bug.cgi?id=178476

This protocol change broke some internal builds (Requested by
brrian__ on #webkit).

Reverted changeset:

"Web Inspector: provide a way to enable/disable event
listeners"
https://bugs.webkit.org/show_bug.cgi?id=177451
https://trac.webkit.org/changeset/223321

2017-10-18 Sam Weinig <sam@webkit.org>

[Settings] Miscellaneous cleanup of the settings generation scripts
@@ -278,9 +278,6 @@ void EventTarget::fireEventListeners(Event& event, EventListenerVector listeners
if (event.eventPhase() == Event::BUBBLING_PHASE && registeredListener->useCapture())
continue;

if (InspectorInstrumentation::isEventListenerDisabled(*this, event.type(), registeredListener->callback(), registeredListener->useCapture()))
continue;

// If stopImmediatePropagation has been called, we just break out immediately, without
// handling any more events on this target.
if (event.immediatePropagationStopped())

0 comments on commit c7ea392

Please sign in to comment.