Permalink
Show file tree
Hide file tree
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Remove build-webkit's notion of feature flags having a default value
https://bugs.webkit.org/show_bug.cgi?id=177338 Reviewed by Carlos Alberto Lopez Perez. .: Add an ENABLE_EXPERIMENTAL_FEATURES flag and use it to enable certain features. * Source/cmake/OptionsGTK.cmake: * Source/cmake/WebKitFeatures.cmake: Source/WebKit: Use ENABLE_EXPERIMENTAL_FEATURES instead of ENABLE_DEVELOPER_MODE to enable runtime experimental features. * Shared/WebPreferencesDefaultValues.h: Tools: Delegate feature flag default values to the build system. (FeatureDefines.xcconfig for Xcode, WebKitFeatures.cmake and Options*.cmake for CMake, and FeatureDefines.h for everyone) * BuildSlaveSupport/build.webkit.org-config/config.json: * BuildSlaveSupport/build.webkit.org-config/master.cfg: (Factory.__init__): Update GTK and WPE buildbot configuration to use --no-experimental-features on old stable bots instead of --default-cmake-features. * Scripts/build-webkit: (cMakeArgsFromFeatures): Deleted. Default feature values to 'undef'. Remove the --default-cmake-features argument; it is now the default. Add --no-experimental-features to replace it. Stop printing the default feature flag value in the help. Avoid propagating undefined values to the build system; only mention flags that are overridden on the command line. This has the nice side effect of using the default CMake features for CMake builds, but still allowing toggling of them using the prettier --FEATURE and --no-FEATURE arguments. * Scripts/webkitdirs.pm: (generateBuildSystemFromCMakeProject): No longer need to suppress CMake warnings about unused arguments. * Scripts/webkitperl/FeatureList.pm: Remove the default values from the feature list. Canonical link: https://commits.webkit.org/195966@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225098 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- Loading branch information
Michael Catanzaro
committed
Nov 22, 2017
1 parent
9690da7
commit c9cef23e05c0feea4b74131c9894be90c6706e5f
Showing
11 changed files
with
176 additions
and
105 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.