Skip to content
Permalink
Browse files
2010-07-15 Shinichiro Hamaji <hamaji@chromium.org>
        Unreviewed build fix.

        Printing test results differ between machines, we should use ImageDiff instead
        https://bugs.webkit.org/show_bug.cgi?id=20011

        * DumpRenderTree/PixelDumpSupport.cpp:
        (dumpWebViewAsPixelsAndCompareWithExpected):

Canonical link: https://commits.webkit.org/54365@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63525 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
Shinichiro Hamaji committed Jul 16, 2010
1 parent 116e93f commit caeb9d00e3bd6dcddac9be1904f297ef34fdddb3
Showing 2 changed files with 12 additions and 0 deletions.
@@ -1,3 +1,13 @@
2010-07-15 Shinichiro Hamaji <hamaji@chromium.org>

Unreviewed build fix.

Printing test results differ between machines, we should use ImageDiff instead
https://bugs.webkit.org/show_bug.cgi?id=20011

* DumpRenderTree/PixelDumpSupport.cpp:
(dumpWebViewAsPixelsAndCompareWithExpected):

2010-07-15 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.
@@ -43,9 +43,11 @@
void dumpWebViewAsPixelsAndCompareWithExpected(const std::string& expectedHash)
{
RefPtr<BitmapContext> context;
#if PLATFORM(MAC)
if (gLayoutTestController->isPrinting())
context = createPagedBitmapContext();
else
#endif
context = createBitmapContextFromWebView(gLayoutTestController->testOnscreen(), gLayoutTestController->testRepaint(), gLayoutTestController->testRepaintSweepHorizontally(), gLayoutTestController->dumpSelectionRect());
ASSERT(context);

0 comments on commit caeb9d0

Please sign in to comment.