Skip to content
Permalink
Browse files
Windows and WebViews are retained after re-configure
https://bugs.webkit.org/show_bug.cgi?id=178902
<rdar://problem/35211518>

Reviewed by Alexey Proskuryakov.

The test runner effectively leaks windows every time a test changes configuration.
We give each test it's own AutoreleasePool to fix this problem.

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::runTest): Add an AutoRelease pool scoping a test run
so that when a configuration changes, the old window and WebView are released.


Canonical link: https://commits.webkit.org/195095@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224124 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
JonWBedard committed Oct 27, 2017
1 parent da3012d commit cb0fec90ddd4a864555ee3564bc5a4df1d5858b7
Showing 2 changed files with 18 additions and 0 deletions.
@@ -1,3 +1,18 @@
2017-10-27 Jonathan Bedard <jbedard@apple.com>

Windows and WebViews are retained after re-configure
https://bugs.webkit.org/show_bug.cgi?id=178902
<rdar://problem/35211518>

Reviewed by Alexey Proskuryakov.

The test runner effectively leaks windows every time a test changes configuration.
We give each test it's own AutoreleasePool to fix this problem.

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::runTest): Add an AutoRelease pool scoping a test run
so that when a configuration changes, the old window and WebView are released.

2017-10-27 Eric Carlson <eric.carlson@apple.com>

NowPlayingInfo should contain a unique identifier
@@ -67,6 +67,7 @@
#include <stdlib.h>
#include <string>
#include <unistd.h>
#include <wtf/AutodrainedPool.h>
#include <wtf/CryptographicallyRandomNumber.h>
#include <wtf/HexNumber.h>
#include <wtf/MainThread.h>
@@ -1176,6 +1177,8 @@ TestCommand parseInputLine(const std::string& inputLine)

bool TestController::runTest(const char* inputLine)
{
AutodrainedPool pool;

WKTextCheckerSetTestingMode(true);
TestCommand command = parseInputLine(std::string(inputLine));

0 comments on commit cb0fec9

Please sign in to comment.