Skip to content
Permalink
Browse files
2009-11-18 Eric Seidel <eric@webkit.org>
        Reviewed by Darin Adler.

        workqueue.py results in totally broken commit-queue UI
        https://bugs.webkit.org/show_bug.cgi?id=31645

        * Scripts/bugzilla-tool:
         - Remove unneeded use of PatchCollection.
         - Grab a new copy of the cq'd patches every run of the queue.

Canonical link: https://commits.webkit.org/42589@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51160 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
eseidel committed Nov 19, 2009
1 parent 07c3064 commit cc4a34233dbd311f673c02d7f6a35c5e3ce3e403
Showing with 14 additions and 6 deletions.
  1. +11 −0 WebKitTools/ChangeLog
  2. +3 −6 WebKitTools/Scripts/bugzilla-tool
@@ -1,3 +1,14 @@
2009-11-18 Eric Seidel <eric@webkit.org>

Reviewed by Darin Adler.

workqueue.py results in totally broken commit-queue UI
https://bugs.webkit.org/show_bug.cgi?id=31645

* Scripts/bugzilla-tool:
- Remove unneeded use of PatchCollection.
- Grab a new copy of the cq'd patches every run of the queue.

2009-11-18 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.
@@ -785,14 +785,11 @@ class CommitQueue(AbstractQueue):

def begin_work_queue(self):
AbstractQueue.begin_work_queue(self)
self._patches = PatchCollection(self.tool.bugs)

def next_work_item(self):
if not len(self._patches):
# Fetch patches instead of just bug ids to that we validate reviewer/committer flags on every patch.
self._patches.add_patches(self.tool.bugs.fetch_patches_from_commit_queue(reject_invalid_patches=True))
self.log_progress(self._patches.patch_ids())
return self._patches.next()
patches = self.tool.bugs.fetch_patches_from_commit_queue(reject_invalid_patches=True)
self.log_progress([patch['id'] for patch in patches])
return patches[0] if patches else None

def should_proceed_with_work_item(self, patch):
red_builders_names = self.tool.buildbot.red_core_builders_names()

0 comments on commit cc4a342

Please sign in to comment.