Skip to content
Permalink
Browse files
[Gtk] Implement setSpatialNavigationEnabled in DRT.
https://bugs.webkit.org/show_bug.cgi?id=35705

Reviewed by Holger Freyther
Patch by Antonio Gomes <tonikitoo@webkit.org>

WebKitTools:

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setSpatialNavigationEnabled):

LayoutTests:

* platform/gtk/Skipped:

Canonical link: https://commits.webkit.org/46882@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55585 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
Antonio Gomes committed Mar 5, 2010
1 parent 6a4cdee commit cd6a894db232cdc61bb4668124d10d4958ae1054
Showing 5 changed files with 29 additions and 4 deletions.
@@ -1,3 +1,13 @@
2010-03-03 Antonio Gomes <tonikitoo@webkit.org>

Reviewed by Holger Freyther
Patch by Antonio Gomes <tonikitoo@webkit.org>

[Gtk] Implement setSpatialNavigationEnabled in DRT.
https://bugs.webkit.org/show_bug.cgi?id=35705

* platform/gtk/Skipped:

2010-03-03 Antonio Gomes <tonikitoo@webkit.org>

Reviewed by Kenneth Christiansen.
@@ -5803,6 +5803,3 @@ fast/dom/Geolocation/permission-denied-already-error.html
fast/dom/Geolocation/permission-denied-already-success.html
fast/dom/Geolocation/permission-denied-stops-watches.html
fast/dom/Geolocation/permission-denied.html

# Need to add functionality to DumpRenderTree to handle enable/disable Spatial Navigation
fast/events/spatial-navigation
@@ -1,5 +1,18 @@
2010-03-02 Antonio Gomes <tonikitoo@webkit.org>

Reviewed by Holger Freyther
Patch by Antonio Gomes <tonikitoo@webkit.org>

[Gtk] Implement setSpatialNavigationEnabled in DRT.
https://bugs.webkit.org/show_bug.cgi?id=35705

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setSpatialNavigationEnabled):

2010-02-23 Antonio Gomes <tonikitoo@webkit.org>

Reviewed by Kenneth Christiansen.
Patch by Antonio Gomes <tonikitoo@webkit.org>

@@ -319,6 +319,7 @@ static void resetDefaultsToConsistentValues()
"enable-html5-database", TRUE,
"enable-html5-local-storage", TRUE,
"enable-xss-auditor", FALSE,
"enable-spatial-navigation", FALSE,
"javascript-can-open-windows-automatically", TRUE,
"enable-offline-web-application-cache", TRUE,
"enable-universal-access-from-file-uris", TRUE,
@@ -341,7 +341,11 @@ void LayoutTestController::setFrameSetFlatteningEnabled(bool flag)

void LayoutTestController::setSpatialNavigationEnabled(bool flag)
{
// FIXME: implement
WebKitWebView* view = webkit_web_frame_get_web_view(mainFrame);
ASSERT(view);

WebKitWebSettings* settings = webkit_web_view_get_settings(view);
g_object_set(G_OBJECT(settings), "enable-spatial-navigation", flag, NULL);
}

void LayoutTestController::setAllowUniversalAccessFromFileURLs(bool flag)

0 comments on commit cd6a894

Please sign in to comment.