Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
[EFL] REGRESSION after r153432: some accessibility tests crash.
https://bugs.webkit.org/show_bug.cgi?id=119333

Patch by Mario Sanchez Prada <mario.prada@samsung.com> on 2013-08-07
Reviewed by Darin Adler.

Use a RefPtr to store a reference to the parent element of
an AccessibilityUIElement instead of the raw pointer, so we
never derefence a function from an invalid pointer.

* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::attributesOfElement): Use a RefPtr instead of a raw pointer.

Canonical link: https://commits.webkit.org/137511@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153798 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
Mario Sanchez Prada authored and webkit-commit-queue committed Aug 7, 2013
1 parent b581270 commit cdc2554
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 1 deletion.
14 changes: 14 additions & 0 deletions Tools/ChangeLog
@@ -1,3 +1,17 @@
2013-08-07 Mario Sanchez Prada <mario.prada@samsung.com>

[EFL] REGRESSION after r153432: some accessibility tests crash.
https://bugs.webkit.org/show_bug.cgi?id=119333

Reviewed by Darin Adler.

Use a RefPtr to store a reference to the parent element of
an AccessibilityUIElement instead of the raw pointer, so we
never derefence a function from an invalid pointer.

* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::attributesOfElement): Use a RefPtr instead of a raw pointer.

2013-08-07 Cosmin Truta <ctruta@blackberry.com>

Unreviewed. Add myself as a committer.
Expand Down
Expand Up @@ -291,7 +291,7 @@ static String attributesOfElement(AccessibilityUIElement* element)

// For the parent we print its role and its name, if available.
builder.append("AXParent: ");
AccessibilityUIElement* parent = element->parentElement().get();
RefPtr<AccessibilityUIElement> parent = element->parentElement();
AtkObject* atkParent = parent ? parent->platformUIElement().get() : 0;
if (atkParent) {
builder.append(roleToString(atk_object_get_role(atkParent)));
Expand Down

0 comments on commit cdc2554

Please sign in to comment.