Skip to content
Permalink
Browse files
2009-11-09 Jeremy Orlow <jorlow@chromium.org>
        Reviewed by Eric Seidel.

        Remove session storage setting
        https://bugs.webkit.org/show_bug.cgi?id=31279

        Remove session storage from Settings.  It was added temporarily so we could
        disable it by default at runtime in Chromium.  We now disable these things in a
        different way, so it's time to remove it.  Qt also depended on this setting for
        a short period of time, but after talking to them we agreed that it should be
        removed.

        This bug is the second half of https://bugs.webkit.org/show_bug.cgi?id=30602

        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::sessionStorage):
        * page/Settings.cpp:
        (WebCore::Settings::Settings):
        * page/Settings.h:


Canonical link: https://commits.webkit.org/42184@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50754 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
Jeremy Orlow committed Nov 10, 2009
1 parent fe610c2 commit ce0ef12e7a8ab5dfbcd87e41683cd6342335d30b
Showing with 21 additions and 13 deletions.
  1. +21 −0 WebCore/ChangeLog
  2. +0 −3 WebCore/page/DOMWindow.cpp
  3. +0 −6 WebCore/page/Settings.cpp
  4. +0 −4 WebCore/page/Settings.h
@@ -1,3 +1,24 @@
2009-11-09 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Eric Seidel.

Remove session storage setting
https://bugs.webkit.org/show_bug.cgi?id=31279

Remove session storage from Settings. It was added temporarily so we could
disable it by default at runtime in Chromium. We now disable these things in a
different way, so it's time to remove it. Qt also depended on this setting for
a short period of time, but after talking to them we agreed that it should be
removed.

This bug is the second half of https://bugs.webkit.org/show_bug.cgi?id=30602

* page/DOMWindow.cpp:
(WebCore::DOMWindow::sessionStorage):
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:

2009-11-10 Dan Bernstein <mitz@apple.com>

Reviewed by Eric Carlson and Darin Adler.
@@ -574,9 +574,6 @@ Storage* DOMWindow::sessionStorage() const
if (!page)
return 0;

if (!page->settings()->sessionStorageEnabled())
return 0;

RefPtr<StorageArea> storageArea = page->sessionStorage()->storageArea(document->securityOrigin());
#if ENABLE(INSPECTOR)
page->inspectorController()->didUseDOMStorage(storageArea.get(), false, m_frame);
@@ -72,7 +72,6 @@ Settings::Settings(Page* page)
, m_arePluginsEnabled(false)
, m_databasesEnabled(false)
, m_localStorageEnabled(false)
, m_sessionStorageEnabled(true)
, m_isJavaScriptEnabled(false)
, m_isWebSecurityEnabled(true)
, m_allowUniversalAccessFromFileURLs(true)
@@ -256,11 +255,6 @@ void Settings::setLocalStorageEnabled(bool localStorageEnabled)
m_localStorageEnabled = localStorageEnabled;
}

void Settings::setSessionStorageEnabled(bool sessionStorageEnabled)
{
m_sessionStorageEnabled = sessionStorageEnabled;
}

void Settings::setLocalStorageQuota(unsigned localStorageQuota)
{
m_localStorageQuota = localStorageQuota;
@@ -125,9 +125,6 @@ namespace WebCore {
void setLocalStorageEnabled(bool);
bool localStorageEnabled() const { return m_localStorageEnabled; }

void setSessionStorageEnabled(bool);
bool sessionStorageEnabled() const { return m_sessionStorageEnabled; }

void setLocalStorageQuota(unsigned);
unsigned localStorageQuota() const { return m_localStorageQuota; }

@@ -307,7 +304,6 @@ namespace WebCore {
bool m_arePluginsEnabled : 1;
bool m_databasesEnabled : 1;
bool m_localStorageEnabled : 1;
bool m_sessionStorageEnabled : 1;
bool m_isJavaScriptEnabled : 1;
bool m_isWebSecurityEnabled : 1;
bool m_allowUniversalAccessFromFileURLs: 1;

0 comments on commit ce0ef12

Please sign in to comment.