Skip to content
Permalink
Browse files
Web Inspector: Some timelines views work, show Legacy CPU timeline
https://bugs.webkit.org/show_bug.cgi?id=194738

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2019-02-15
Reviewed by Yusuke Suzuki.

* UserInterface/Views/ContentView.js:
(WI.ContentView.createFromRepresentedObject):

Canonical link: https://commits.webkit.org/209135@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@241642 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
JosephPecoraro authored and webkit-commit-queue committed Feb 16, 2019
1 parent 98c95b6 commit cf1a8ad0838aa90dbf4d0cbd493d085d482496d8
Showing 2 changed files with 12 additions and 1 deletion.
@@ -1,3 +1,13 @@
2019-02-15 Joseph Pecoraro <pecoraro@apple.com>

Web Inspector: Some timelines views work, show Legacy CPU timeline
https://bugs.webkit.org/show_bug.cgi?id=194738

Reviewed by Yusuke Suzuki.

* UserInterface/Views/ContentView.js:
(WI.ContentView.createFromRepresentedObject):

2019-02-15 Aaron Chu <aaron_chu@apple.com>

AX: Audit tab should have built-in accessibility tests.
@@ -83,10 +83,11 @@ WI.ContentView = class ContentView extends WI.View
if (timelineType === WI.TimelineRecord.Type.RenderingFrame)
return new WI.RenderingFrameTimelineView(representedObject, extraArguments);

if (timelineType === WI.TimelineRecord.Type.CPU)
if (timelineType === WI.TimelineRecord.Type.CPU) {
if (WI.settings.experimentalEnableCPUUsageEnhancements.value)
return new WI.CPUTimelineView(representedObject, extraArguments);
return new WI.LegacyCPUTimelineView(representedObject, extraArguments);
}

if (timelineType === WI.TimelineRecord.Type.Memory)
return new WI.MemoryTimelineView(representedObject, extraArguments);

0 comments on commit cf1a8ad

Please sign in to comment.