Skip to content
Permalink
Browse files
Move lazy DisplayLink tear down logic from the WebProcess to the UIPr…
…ocess

https://bugs.webkit.org/show_bug.cgi?id=216195

Reviewed by Simon Fraser.

Move lazy DisplayLink tear down logic from the WebProcess to the UIProcess, now that the
DisplayLink has been moved to the UIProcess due to sandboxing.

After a DisplayLink no longer has any clients, we keep it firing up to 20 times without
any clients in case a new client gets added shortly after. The idea was to avoid killing
and respawning too many threads when adding and removing clients in quick succession.
However, now that the DisplayLink lives in the UIProcess side and sends IPC to the
WebProcesses every time it fires, it makes a lot more sense to implement this logic in
the UIProcess side, to avoid sending unnecessary IPC to processes that do not care about
it.

Source/WebCore:

* platform/graphics/DisplayRefreshMonitor.cpp:
(WebCore::DisplayRefreshMonitor::displayDidRefresh):
* platform/graphics/DisplayRefreshMonitor.h:
(WebCore::DisplayRefreshMonitor::shouldBeTerminated const):

Source/WebKit:

* UIProcess/mac/DisplayLink.cpp:
(WebKit::DisplayLink::addObserver):
(WebKit::DisplayLink::removeObserver):
(WebKit::DisplayLink::removeObservers):
(WebKit::DisplayLink::displayLinkCallback):
(WebKit::DisplayLink::hasObservers const): Deleted.
* UIProcess/mac/DisplayLink.h:


Canonical link: https://commits.webkit.org/229158@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266797 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
cdumez committed Sep 9, 2020
1 parent 99f2835 commit cfaa041f29314112ee968f62d0a3f425465e68f4
@@ -1,3 +1,26 @@
2020-09-09 Chris Dumez <cdumez@apple.com>

Move lazy DisplayLink tear down logic from the WebProcess to the UIProcess
https://bugs.webkit.org/show_bug.cgi?id=216195

Reviewed by Simon Fraser.

Move lazy DisplayLink tear down logic from the WebProcess to the UIProcess, now that the
DisplayLink has been moved to the UIProcess due to sandboxing.

After a DisplayLink no longer has any clients, we keep it firing up to 20 times without
any clients in case a new client gets added shortly after. The idea was to avoid killing
and respawning too many threads when adding and removing clients in quick succession.
However, now that the DisplayLink lives in the UIProcess side and sends IPC to the
WebProcesses every time it fires, it makes a lot more sense to implement this logic in
the UIProcess side, to avoid sending unnecessary IPC to processes that do not care about
it.

* platform/graphics/DisplayRefreshMonitor.cpp:
(WebCore::DisplayRefreshMonitor::displayDidRefresh):
* platform/graphics/DisplayRefreshMonitor.h:
(WebCore::DisplayRefreshMonitor::shouldBeTerminated const):

2020-09-09 Chris Dumez <cdumez@apple.com>

Stop performing "de-zippering" when applying gain
@@ -62,7 +62,7 @@ class DisplayRefreshMonitor : public ThreadSafeRefCounted<DisplayRefreshMonitor>

bool shouldBeTerminated() const
{
const int maxInactiveFireCount = 20;
const int maxInactiveFireCount = 1;
return !m_scheduled && m_unscheduledFireCount > maxInactiveFireCount;
}

@@ -1,3 +1,29 @@
2020-09-09 Chris Dumez <cdumez@apple.com>

Move lazy DisplayLink tear down logic from the WebProcess to the UIProcess
https://bugs.webkit.org/show_bug.cgi?id=216195

Reviewed by Simon Fraser.

Move lazy DisplayLink tear down logic from the WebProcess to the UIProcess, now that the
DisplayLink has been moved to the UIProcess due to sandboxing.

After a DisplayLink no longer has any clients, we keep it firing up to 20 times without
any clients in case a new client gets added shortly after. The idea was to avoid killing
and respawning too many threads when adding and removing clients in quick succession.
However, now that the DisplayLink lives in the UIProcess side and sends IPC to the
WebProcesses every time it fires, it makes a lot more sense to implement this logic in
the UIProcess side, to avoid sending unnecessary IPC to processes that do not care about
it.

* UIProcess/mac/DisplayLink.cpp:
(WebKit::DisplayLink::addObserver):
(WebKit::DisplayLink::removeObserver):
(WebKit::DisplayLink::removeObservers):
(WebKit::DisplayLink::displayLinkCallback):
(WebKit::DisplayLink::hasObservers const): Deleted.
* UIProcess/mac/DisplayLink.h:

2020-09-08 Chris Dumez <cdumez@apple.com>

Regression(r260614) Power usage has increased due to extra thread hopping
@@ -34,6 +34,7 @@
namespace WebKit {

bool DisplayLink::shouldSendIPCOnBackgroundQueue { false };
constexpr unsigned maxFireCountWithoutObservers { 20 };

DisplayLink::DisplayLink(WebCore::PlatformDisplayID displayID)
: m_displayID(displayID)
@@ -74,7 +75,6 @@ Optional<unsigned> DisplayLink::nominalFramesPerSecond() const
void DisplayLink::addObserver(IPC::Connection& connection, DisplayLinkObserverID observerID)
{
ASSERT(RunLoop::isMain());
bool isRunning = !m_observers.isEmpty();

{
LockHolder locker(m_observersLock);
@@ -83,7 +83,7 @@ void DisplayLink::addObserver(IPC::Connection& connection, DisplayLinkObserverID
}).iterator->value.append(observerID);
}

if (!isRunning) {
if (!CVDisplayLinkIsRunning(m_displayLink)) {
CVReturn error = CVDisplayLinkStart(m_displayLink);
if (error)
WTFLogAlways("Could not start the display link: %d", error);
@@ -94,52 +94,57 @@ void DisplayLink::removeObserver(IPC::Connection& connection, DisplayLinkObserve
{
ASSERT(RunLoop::isMain());

{
LockHolder locker(m_observersLock);
LockHolder locker(m_observersLock);

auto it = m_observers.find(&connection);
if (it == m_observers.end())
return;
bool removed = it->value.removeFirst(observerID);
ASSERT_UNUSED(removed, removed);
if (it->value.isEmpty())
m_observers.remove(it);
}

if (m_observers.isEmpty())
CVDisplayLinkStop(m_displayLink);
auto it = m_observers.find(&connection);
if (it == m_observers.end())
return;
bool removed = it->value.removeFirst(observerID);
ASSERT_UNUSED(removed, removed);
if (it->value.isEmpty())
m_observers.remove(it);

// We do not stop the display link right away when |m_observers| becomes empty. Instead, we
// let the display link fire up to |maxFireCountWithoutObservers| times without observers to avoid
// killing & restarting too many threads when observers gets removed & added in quick succession.
}

void DisplayLink::removeObservers(IPC::Connection& connection)
{
ASSERT(RunLoop::isMain());

{
LockHolder locker(m_observersLock);
m_observers.remove(&connection);
}
LockHolder locker(m_observersLock);
m_observers.remove(&connection);

if (m_observers.isEmpty())
CVDisplayLinkStop(m_displayLink);
// We do not stop the display link right away when |m_observers| becomes empty. Instead, we
// let the display link fire up to |maxFireCountWithoutObservers| times without observers to avoid
// killing & restarting too many threads when observers gets removed & added in quick succession.
}

bool DisplayLink::hasObservers() const
CVReturn DisplayLink::displayLinkCallback(CVDisplayLinkRef displayLinkRef, const CVTimeStamp*, const CVTimeStamp*, CVOptionFlags, CVOptionFlags*, void* data)
{
ASSERT(RunLoop::isMain());
return !m_observers.isEmpty();
static_cast<DisplayLink*>(data)->notifyObserversDisplayWasRefreshed();
return kCVReturnSuccess;
}

CVReturn DisplayLink::displayLinkCallback(CVDisplayLinkRef displayLinkRef, const CVTimeStamp*, const CVTimeStamp*, CVOptionFlags, CVOptionFlags*, void* data)
void DisplayLink::notifyObserversDisplayWasRefreshed()
{
auto* displayLink = static_cast<DisplayLink*>(data);
LockHolder locker(displayLink->m_observersLock);
for (auto& connection : displayLink->m_observers.keys()) {
ASSERT(!RunLoop::isMain());

LockHolder locker(m_observersLock);
if (m_observers.isEmpty()) {
if (++m_fireCountWithoutObservers >= maxFireCountWithoutObservers)
CVDisplayLinkStop(m_displayLink);
return;
}
m_fireCountWithoutObservers = 0;

for (auto& connection : m_observers.keys()) {
if (shouldSendIPCOnBackgroundQueue)
connection->send(Messages::EventDispatcher::DisplayWasRefreshed(displayLink->m_displayID), 0);
connection->send(Messages::EventDispatcher::DisplayWasRefreshed(m_displayID), 0);
else
connection->send(Messages::WebProcess::DisplayWasRefreshed(displayLink->m_displayID), 0);
connection->send(Messages::WebProcess::DisplayWasRefreshed(m_displayID), 0);
}
return kCVReturnSuccess;
}

} // namespace WebKit
@@ -48,7 +48,6 @@ class DisplayLink {
void addObserver(IPC::Connection&, DisplayLinkObserverID);
void removeObserver(IPC::Connection&, DisplayLinkObserverID);
void removeObservers(IPC::Connection&);
bool hasObservers() const;

WebCore::PlatformDisplayID displayID() const { return m_displayID; }

@@ -60,11 +59,13 @@ class DisplayLink {

private:
static CVReturn displayLinkCallback(CVDisplayLinkRef, const CVTimeStamp*, const CVTimeStamp*, CVOptionFlags, CVOptionFlags*, void* data);

void notifyObserversDisplayWasRefreshed();

CVDisplayLinkRef m_displayLink { nullptr };
Lock m_observersLock;
HashMap<RefPtr<IPC::Connection>, Vector<DisplayLinkObserverID>> m_observers;
WebCore::PlatformDisplayID m_displayID;
unsigned m_fireCountWithoutObservers { 0 };
static bool shouldSendIPCOnBackgroundQueue;
};

0 comments on commit cfaa041

Please sign in to comment.