Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
LayoutTests:
        Reviewed by Adam and Darin.

        - update results for http://bugs.webkit.org/show_bug.cgi?id=13791
          to account for new JSHTMLElements that are being autogenerated and
          can now produce constructors.

        * fast/dom/Window/element-constructors-on-window-expected.txt:
        * fast/dom/Window/window-properties-expected.txt:

WebCore:

        Reviewed by Adam and Darin.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=13791
        Autogenerate the JS bindings for the HTMLIFrameElement and HTMLFrameElement.

        * DerivedSources.make:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSHTMLAnchorElementCustom.cpp:
        * bindings/js/JSHTMLElementWrapperFactory.cpp:
        * bindings/js/kjs_html.cpp:
        (KJS::):
        (KJS::JSHTMLElement::classInfo):
        (KJS::JSHTMLElement::accessors):
        (KJS::HTMLElementFunction::callAsFunction):
        * bindings/js/kjs_html.h:
        (KJS::JSHTMLElement::):
        * bindings/scripts/CodeGeneratorJS.pm:
        * html/HTMLFrameElement.idl:
        * html/HTMLFrameElementBase.cpp:
        (WebCore::HTMLFrameElementBase::location):
        * html/HTMLFrameElementBase.h:
        * html/HTMLFrameOwnerElement.h:
        (WebCore::HTMLFrameOwnerElement::contentWindow):
        * html/HTMLIFrameElement.idl:
        * page/DOMWindow.idl:



Canonical link: https://commits.webkit.org/18051@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21624 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
Sam Weinig committed May 21, 2007
1 parent e641446 commit d05ebad
Show file tree
Hide file tree
Showing 17 changed files with 139 additions and 170 deletions.
11 changes: 11 additions & 0 deletions LayoutTests/ChangeLog
@@ -1,3 +1,14 @@
2007-05-21 Sam Weinig <sam@webkit.org>

Reviewed by Adam and Darin.

- update results for http://bugs.webkit.org/show_bug.cgi?id=13791
to account for new JSHTMLElements that are being autogenerated and
can now produce constructors.

* fast/dom/Window/element-constructors-on-window-expected.txt:
* fast/dom/Window/window-properties-expected.txt:

2007-05-19 Mitz Pettel <mitz@webkit.org>

Reviewed by Dave Hyatt.
Expand Down
Expand Up @@ -30,7 +30,7 @@ HTMLFontElement: [object HTMLFontElementConstructor]

HTMLFormElement: [object HTMLFormElementConstructor]

HTMLFrameElement: undefined
HTMLFrameElement: [object HTMLFrameElementConstructor]

HTMLFrameSetElement: undefined

Expand All @@ -42,7 +42,7 @@ HTMLHRElement: [object HTMLHRElementConstructor]

HTMLHtmlElement: [object HTMLHtmlElementConstructor]

HTMLIFrameElement: undefined
HTMLIFrameElement: [object HTMLIFrameElementConstructor]

HTMLImageElement: [object HTMLImageElementConstructor]

Expand Down
4 changes: 4 additions & 0 deletions LayoutTests/fast/dom/Window/window-properties-expected.txt
Expand Up @@ -528,6 +528,8 @@ window.HTMLFontElement [object HTMLFontElementConstructor]
window.HTMLFontElement.prototype [printed above as window.Element.prototype]
window.HTMLFormElement [object HTMLFormElementConstructor]
window.HTMLFormElement.prototype [printed above as window.Element.prototype]
window.HTMLFrameElement [object HTMLFrameElementConstructor]
window.HTMLFrameElement.prototype [printed above as window.Element.prototype]
window.HTMLHRElement [object HTMLHRElementConstructor]
window.HTMLHRElement.prototype [printed above as window.Element.prototype]
window.HTMLHeadElement [object HTMLHeadElementConstructor]
Expand All @@ -536,6 +538,8 @@ window.HTMLHeadingElement [object HTMLHeadingElementConstructor]
window.HTMLHeadingElement.prototype [printed above as window.Element.prototype]
window.HTMLHtmlElement [object HTMLHtmlElementConstructor]
window.HTMLHtmlElement.prototype [printed above as window.Element.prototype]
window.HTMLIFrameElement [object HTMLIFrameElementConstructor]
window.HTMLIFrameElement.prototype [printed above as window.Element.prototype]
window.HTMLImageElement [object HTMLImageElementConstructor]
window.HTMLImageElement.prototype [printed above as window.Element.prototype]
window.HTMLInputElement [object HTMLInputElementConstructor]
Expand Down
28 changes: 28 additions & 0 deletions WebCore/ChangeLog
@@ -1,3 +1,31 @@
2007-05-21 Sam Weinig <sam@webkit.org>

Reviewed by Adam and Darin.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13791
Autogenerate the JS bindings for the HTMLIFrameElement and HTMLFrameElement.

* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSHTMLAnchorElementCustom.cpp:
* bindings/js/JSHTMLElementWrapperFactory.cpp:
* bindings/js/kjs_html.cpp:
(KJS::):
(KJS::JSHTMLElement::classInfo):
(KJS::JSHTMLElement::accessors):
(KJS::HTMLElementFunction::callAsFunction):
* bindings/js/kjs_html.h:
(KJS::JSHTMLElement::):
* bindings/scripts/CodeGeneratorJS.pm:
* html/HTMLFrameElement.idl:
* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::location):
* html/HTMLFrameElementBase.h:
* html/HTMLFrameOwnerElement.h:
(WebCore::HTMLFrameOwnerElement::contentWindow):
* html/HTMLIFrameElement.idl:
* page/DOMWindow.idl:

2007-05-21 Lars Knoll <lars@trolltech.com>

Reviewed by Zack.
Expand Down
22 changes: 12 additions & 10 deletions WebCore/DerivedSources.make
Expand Up @@ -331,38 +331,40 @@ all : \
JSHTMLBRElement.h \
JSHTMLButtonElement.h \
JSHTMLCanvasElement.h \
JSHTMLDListElement.h \
JSHTMLDirectoryElement.h \
JSHTMLDivElement.h \
JSHTMLDListElement.h \
JSHTMLDocument.h \
JSHTMLElement.h \
JSHTMLFieldSetElement.h \
JSHTMLFontElement.h \
JSHTMLFormElement.h \
JSHTMLFrameElement.h \
JSHTMLHRElement.h \
JSHTMLHeadElement.h \
JSHTMLHeadingElement.h \
JSHTMLHRElement.h \
JSHTMLImageElement.h \
JSHTMLIsIndexElement.h \
JSHTMLHtmlElement.h \
JSHTMLIFrameElement.h \
JSHTMLImageElement.h \
JSHTMLInputElement.h \
JSHTMLInputElementBaseTable.cpp \
JSHTMLIsIndexElement.h \
JSHTMLLIElement.h \
JSHTMLLabelElement.h \
JSHTMLLegendElement.h \
JSHTMLLIElement.h \
JSHTMLLinkElement.h \
JSHTMLMenuElement.h \
JSHTMLOptionElement.h \
JSHTMLOptionsCollection.h \
JSHTMLOptGroupElement.h \
JSHTMLQuoteElement.h \
JSHTMLMapElement.h \
JSHTMLMenuElement.h \
JSHTMLMetaElement.h \
JSHTMLModElement.h \
JSHTMLOListElement.h \
JSHTMLOptGroupElement.h \
JSHTMLOptionElement.h \
JSHTMLOptionsCollection.h \
JSHTMLParagraphElement.h \
JSHTMLParamElement.h \
JSHTMLPreElement.h \
JSHTMLQuoteElement.h \
JSHTMLScriptElement.h \
JSHTMLSelectElement.h \
JSHTMLStyleElement.h \
Expand Down
16 changes: 16 additions & 0 deletions WebCore/WebCore.xcodeproj/project.pbxproj
Expand Up @@ -2760,6 +2760,10 @@
BC1A37BF097C715F0019F3D8 /* DOMUtility.mm in Sources */ = {isa = PBXBuildFile; fileRef = BC1A37A9097C715F0019F3D8 /* DOMUtility.mm */; };
BC1A37C0097C715F0019F3D8 /* DOMViews.h in Headers */ = {isa = PBXBuildFile; fileRef = BC1A37AA097C715F0019F3D8 /* DOMViews.h */; settings = {ATTRIBUTES = (Private, ); }; };
BC3FCAA90AC3DB5800BA54AD /* PlatformScrollBar.h in Headers */ = {isa = PBXBuildFile; fileRef = BC3FCAA80AC3DB5800BA54AD /* PlatformScrollBar.h */; settings = {ATTRIBUTES = (); }; };
BC4918C60BFEA050009D6316 /* JSHTMLFrameElement.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BC4918C00BFEA050009D6316 /* JSHTMLFrameElement.cpp */; };
BC4918C70BFEA050009D6316 /* JSHTMLFrameElement.h in Headers */ = {isa = PBXBuildFile; fileRef = BC4918C10BFEA050009D6316 /* JSHTMLFrameElement.h */; };
BC4918C80BFEA050009D6316 /* JSHTMLIFrameElement.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BC4918C20BFEA050009D6316 /* JSHTMLIFrameElement.cpp */; };
BC4918C90BFEA050009D6316 /* JSHTMLIFrameElement.h in Headers */ = {isa = PBXBuildFile; fileRef = BC4918C30BFEA050009D6316 /* JSHTMLIFrameElement.h */; };
BC588AF00BFA6CF900EE679E /* HTMLParserErrorCodes.h in Headers */ = {isa = PBXBuildFile; fileRef = BC588AEF0BFA6CF900EE679E /* HTMLParserErrorCodes.h */; };
BC588B4B0BFA723C00EE679E /* HTMLParserErrorCodes.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BC588B4A0BFA723C00EE679E /* HTMLParserErrorCodes.cpp */; };
BC6D6DD209AF906600F59759 /* Font.cpp in Sources */ = {isa = PBXBuildFile; fileRef = BC6D6DD009AF906600F59759 /* Font.cpp */; };
Expand Down Expand Up @@ -5982,6 +5986,10 @@
BC1A37AA097C715F0019F3D8 /* DOMViews.h */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.c.h; path = DOMViews.h; sourceTree = "<group>"; };
BC3B364705C9D5E200E42902 /* AtomicStringList.h */ = {isa = PBXFileReference; fileEncoding = 30; indentWidth = 4; lastKnownFileType = sourcecode.c.h; path = AtomicStringList.h; sourceTree = "<group>"; tabWidth = 8; usesTabs = 0; };
BC3FCAA80AC3DB5800BA54AD /* PlatformScrollBar.h */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.c.h; path = PlatformScrollBar.h; sourceTree = "<group>"; };
BC4918C00BFEA050009D6316 /* JSHTMLFrameElement.cpp */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.cpp.cpp; path = JSHTMLFrameElement.cpp; sourceTree = "<group>"; };
BC4918C10BFEA050009D6316 /* JSHTMLFrameElement.h */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.c.h; path = JSHTMLFrameElement.h; sourceTree = "<group>"; };
BC4918C20BFEA050009D6316 /* JSHTMLIFrameElement.cpp */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.cpp.cpp; path = JSHTMLIFrameElement.cpp; sourceTree = "<group>"; };
BC4918C30BFEA050009D6316 /* JSHTMLIFrameElement.h */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.c.h; path = JSHTMLIFrameElement.h; sourceTree = "<group>"; };
BC588AEF0BFA6CF900EE679E /* HTMLParserErrorCodes.h */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.c.h; path = HTMLParserErrorCodes.h; sourceTree = "<group>"; };
BC588B4A0BFA723C00EE679E /* HTMLParserErrorCodes.cpp */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.cpp.cpp; path = HTMLParserErrorCodes.cpp; sourceTree = "<group>"; };
BC5EC1760A507E3E006007F5 /* view-source.css */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = text; path = "view-source.css"; sourceTree = "<group>"; };
Expand Down Expand Up @@ -6330,6 +6338,10 @@
14DFB33F0A7DF7630018F769 /* Derived Sources */ = {
isa = PBXGroup;
children = (
BC4918C00BFEA050009D6316 /* JSHTMLFrameElement.cpp */,
BC4918C10BFEA050009D6316 /* JSHTMLFrameElement.h */,
BC4918C20BFEA050009D6316 /* JSHTMLIFrameElement.cpp */,
BC4918C30BFEA050009D6316 /* JSHTMLIFrameElement.h */,
65DF31D809D1C122000BE325 /* JSAttr.cpp */,
65DF31D909D1C123000BE325 /* JSAttr.h */,
65DF323309D1DE65000BE325 /* JSCanvasGradient.cpp */,
Expand Down Expand Up @@ -11323,6 +11335,8 @@
BC06EDA00BFD660600856E9D /* JSHTMLTableRowElement.h in Headers */,
BC06EDE40BFD6D0D00856E9D /* JSHTMLTableCellElement.h in Headers */,
BC06EE050BFD71AA00856E9D /* JSHTMLTableElement.h in Headers */,
BC4918C70BFEA050009D6316 /* JSHTMLFrameElement.h in Headers */,
BC4918C90BFEA050009D6316 /* JSHTMLIFrameElement.h in Headers */,
);
runOnlyForDeploymentPostprocessing = 0;
};
Expand Down Expand Up @@ -12705,6 +12719,8 @@
BC06ED9F0BFD660600856E9D /* JSHTMLTableRowElement.cpp in Sources */,
BC06EDE30BFD6D0D00856E9D /* JSHTMLTableCellElement.cpp in Sources */,
BC06EE040BFD71AA00856E9D /* JSHTMLTableElement.cpp in Sources */,
BC4918C60BFEA050009D6316 /* JSHTMLFrameElement.cpp in Sources */,
BC4918C80BFEA050009D6316 /* JSHTMLIFrameElement.cpp in Sources */,
);
runOnlyForDeploymentPostprocessing = 0;
};
Expand Down
2 changes: 1 addition & 1 deletion WebCore/bindings/js/JSHTMLAnchorElementCustom.cpp
@@ -1,5 +1,5 @@
/*
* Copyright (C) 2007 Apple, Inc.
* Copyright (C) 2007 Apple Inc. All rights reserved.
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Library General Public
Expand Down
10 changes: 8 additions & 2 deletions WebCore/bindings/js/JSHTMLElementWrapperFactory.cpp
Expand Up @@ -35,10 +35,12 @@
#include "HTMLFieldSetElement.h"
#include "HTMLFontElement.h"
#include "HTMLFormElement.h"
#include "HTMLFrameElement.h"
#include "HTMLHRElement.h"
#include "HTMLHeadElement.h"
#include "HTMLHeadingElement.h"
#include "HTMLHtmlElement.h"
#include "HTMLIFrameElement.h"
#include "HTMLImageElement.h"
#include "HTMLInputElement.h"
#include "HTMLIsIndexElement.h"
Expand Down Expand Up @@ -88,10 +90,12 @@
#include "JSHTMLFieldSetElement.h"
#include "JSHTMLFontElement.h"
#include "JSHTMLFormElement.h"
#include "JSHTMLFrameElement.h"
#include "JSHTMLHRElement.h"
#include "JSHTMLHeadElement.h"
#include "JSHTMLHeadingElement.h"
#include "JSHTMLHtmlElement.h"
#include "JSHTMLIFrameElement.h"
#include "JSHTMLImageElement.h"
#include "JSHTMLInputElement.h"
#include "JSHTMLIsIndexElement.h"
Expand Down Expand Up @@ -145,20 +149,22 @@ typedef DOMNode* (*CreateHTMLElementWrapperFunction)(ExecState*, PassRefPtr<HTML
macro(body, Body) \
macro(br, BR) \
macro(button, Button) \
macro(caption, TableCaption) \
macro(canvas, Canvas) \
macro(caption, TableCaption) \
macro(col, TableCol) \
macro(del, Mod) \
macro(dir, Directory) \
macro(div, Div) \
macro(dl, DList) \
macro(fieldset, FieldSet) \
macro(form, Form) \
macro(font, Font) \
macro(form, Form) \
macro(frame, Frame) \
macro(h1, Heading) \
macro(head, Head) \
macro(hr, HR) \
macro(html, Html) \
macro(iframe, IFrame) \
macro(img, Image) \
macro(input, Input) \
macro(isindex, IsIndex) \
Expand Down

0 comments on commit d05ebad

Please sign in to comment.