Skip to content
Permalink
Browse files
2011-01-21 Adam Barth <abarth@webkit.org>
        Reviewed by Maciej Stachowiak.

        Disable mac_unittest.py that fails on some of the Mac bots
        https://bugs.webkit.org/show_bug.cgi?id=52947

        As noted in the comment, this test does not appear to be correct
        because the function this test is testing returns different results
        depending on which flavor of Mac the test is run on.  This patch
        disable the test.  Hopefully we can re-enable the test once we've
        probably insulated the test from its environment.

        * Scripts/webkitpy/layout_tests/port/mac_unittest.py:


Canonical link: https://commits.webkit.org/66662@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76428 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
Adam Barth committed Jan 22, 2011
1 parent 6162fe1 commit d274ed14debbad5506c386079830d16818c67dbb
Showing 2 changed files with 19 additions and 1 deletion.
@@ -1,3 +1,18 @@
2011-01-21 Adam Barth <abarth@webkit.org>

Reviewed by Maciej Stachowiak.

Disable mac_unittest.py that fails on some of the Mac bots
https://bugs.webkit.org/show_bug.cgi?id=52947

As noted in the comment, this test does not appear to be correct
because the function this test is testing returns different results
depending on which flavor of Mac the test is run on. This patch
disable the test. Hopefully we can re-enable the test once we've
probably insulated the test from its environment.

* Scripts/webkitpy/layout_tests/port/mac_unittest.py:

2011-01-21 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.
@@ -43,7 +43,10 @@ def make_port(self, options=port_testcase.mock_options):
port_obj._options.configuration = 'Release'
return port_obj

def test_skipped_file_paths(self):
# FIXME: This test does not appear to be correct. It seems to receive
# different answers on different platforms. We should consider re-enabling
# it once we've worked out how to make it correct.
def disabled_test_skipped_file_paths(self):
port = self.make_port()
if not port:
return

0 comments on commit d274ed1

Please sign in to comment.