Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
[GTK] [WebKit2] CanHandleRequest API test fails
https://bugs.webkit.org/show_bug.cgi?id=88453

Patch by Anton Obzhirov <a.obzhirov@samsung.com> on 2013-10-25
Reviewed by Martin Robinson.

Source/WebKit2:

Make WebPage::platformCanHandleRequest return false by default
for unknown schemes.

* WebProcess/WebPage/gtk/WebPageGtk.cpp:
(WebKit::WebPage::platformCanHandleRequest):

Tools:

* Scripts/run-gtk-tests:
(TestRunner):

Canonical link: https://commits.webkit.org/141428@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@158002 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
Anton Obzhirov authored and webkit-commit-queue committed Oct 25, 2013
1 parent faa3ee3 commit d349786
Show file tree
Hide file tree
Showing 4 changed files with 24 additions and 2 deletions.
13 changes: 13 additions & 0 deletions Source/WebKit2/ChangeLog
@@ -1,3 +1,16 @@
2013-10-25 Anton Obzhirov <a.obzhirov@samsung.com>

[GTK] [WebKit2] CanHandleRequest API test fails
https://bugs.webkit.org/show_bug.cgi?id=88453

Reviewed by Martin Robinson.

Make WebPage::platformCanHandleRequest return false by default
for unknown schemes.

* WebProcess/WebPage/gtk/WebPageGtk.cpp:
(WebKit::WebPage::platformCanHandleRequest):

2013-10-25 Ryuan Choi <ryuan.choi@samsung.com>

[EFL][WK2] Build break after r157967 and r157972
Expand Down
2 changes: 1 addition & 1 deletion Source/WebKit2/WebProcess/WebPage/gtk/WebPageGtk.cpp
Expand Up @@ -141,7 +141,7 @@ String WebPage::cachedResponseMIMETypeForURL(const URL&)
bool WebPage::platformCanHandleRequest(const ResourceRequest&)
{
notImplemented();
return true;
return false;
}

String WebPage::cachedSuggestedFilenameForURL(const URL&)
Expand Down
10 changes: 10 additions & 0 deletions Tools/ChangeLog
@@ -1,3 +1,13 @@
2013-10-25 Anton Obzhirov <a.obzhirov@samsung.com>

[GTK] [WebKit2] CanHandleRequest API test fails
https://bugs.webkit.org/show_bug.cgi?id=88453

Reviewed by Martin Robinson.

* Scripts/run-gtk-tests:
(TestRunner):

2013-10-25 Ryosuke Niwa <rniwa@webkit.org>

Build fix after r157815. Don't resolve the path from webkit_base. Use the relative path as is.
Expand Down
1 change: 0 additions & 1 deletion Tools/Scripts/run-gtk-tests
Expand Up @@ -69,7 +69,6 @@ class TestRunner:
SkippedTest("WebKit2APITests/TestResources", "/webkit2/WebKitWebView/resources", "Test is flaky in GTK Linux 32-bit Release bot", 82868),
SkippedTest("WebKit2APITests/TestWebKitWebView", SkippedTest.ENTIRE_SUITE, "Test times out after r150890", 117689),
SkippedTest("WebKit2APITests/TestContextMenu", SkippedTest.ENTIRE_SUITE, "Test times out after r150890", 117689),
SkippedTest("TestWebKitAPI/TestWebKit2", "WebKit2.CanHandleRequest", "Test fails", 88453),
SkippedTest("TestWebKitAPI/TestWebKit2", "WebKit2.MouseMoveAfterCrash", "Test is flaky", 85066),
SkippedTest("TestWebKitAPI/TestWebKit2", "WebKit2.NewFirstVisuallyNonEmptyLayoutForImages", "Test is flaky", 85066),
SkippedTest("TestWebKitAPI/TestWebKit2", "WebKit2.NewFirstVisuallyNonEmptyLayoutFrames", "Test fails", 85037),
Expand Down

0 comments on commit d349786

Please sign in to comment.