Skip to content
Permalink
Browse files
REGRESSION(r195661): [GTK] Scrollbar tests crashing after overlay scr…
…ollbar groundwork

https://bugs.webkit.org/show_bug.cgi?id=153695

Reviewed by Michael Catanzaro.

Source/WebCore:

The problem is that ScrollAnimation objects are not destroyed by
the ScrollAnimator destructor, because I forgot to add a virtual
destructor for ScrollAnimation in r195661.

* platform/ScrollAnimation.h:
(WebCore::ScrollAnimation::~ScrollAnimation):

LayoutTests:

* platform/gtk/TestExpectations:

Canonical link: https://commits.webkit.org/172065@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196238 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
carlosgcampos committed Feb 7, 2016
1 parent ded2817 commit d4083358c74364c7d6c1c04cc0f3a6e4666106ad
Showing 4 changed files with 24 additions and 6 deletions.
@@ -1,3 +1,12 @@
2016-02-07 Carlos Garcia Campos <cgarcia@igalia.com>

REGRESSION(r195661): [GTK] Scrollbar tests crashing after overlay scrollbar groundwork
https://bugs.webkit.org/show_bug.cgi?id=153695

Reviewed by Michael Catanzaro.

* platform/gtk/TestExpectations:

2016-02-06 Chris Dumez <cdumez@apple.com>

Unreviewed, update several layout tests for WK1 after r196227.
@@ -735,12 +735,6 @@ webkit.org/b/153060 imported/blink/editing/selection/selectstart-event-crash.htm

webkit.org/b/153692 imported/blink/fast/css/first-letter-float-block.html [ Crash Pass ]

webkit.org/b/153695 fast/repaint/fixed-move-after-scroll.html [ Crash Pass ]
webkit.org/b/153695 fast/scrolling/scroll-position-on-reload-rtl.html [ Crash Pass ]
webkit.org/b/153695 scrollbars/scrollbar-initial-position.html [ Crash Pass ]

webkit.org/b/153936 editing/input/password-echo-passnode2.html [ Crash Pass ]

webkit.org/b/117756 media/track/media-element-enqueue-event-crash.html [ Timeout Pass Crash ]

webkit.org/b/153937 http/tests/misc/detach-during-notifyDone.html [ Crash Pass ]
@@ -1,3 +1,17 @@
2016-02-07 Carlos Garcia Campos <cgarcia@igalia.com>

REGRESSION(r195661): [GTK] Scrollbar tests crashing after overlay scrollbar groundwork
https://bugs.webkit.org/show_bug.cgi?id=153695

Reviewed by Michael Catanzaro.

The problem is that ScrollAnimation objects are not destroyed by
the ScrollAnimator destructor, because I forgot to add a virtual
destructor for ScrollAnimation in r195661.

* platform/ScrollAnimation.h:
(WebCore::ScrollAnimation::~ScrollAnimation):

2016-02-06 Chris Dumez <cdumez@apple.com>

Prevent cross-origin access to window.history
@@ -35,6 +35,7 @@ class ScrollableArea;

class ScrollAnimation {
public:
virtual ~ScrollAnimation() { };
virtual bool scroll(ScrollbarOrientation, ScrollGranularity, float step, float multiplier) = 0;
virtual void stop() = 0;
virtual void updateVisibleLengths() = 0;

0 comments on commit d408335

Please sign in to comment.