Skip to content
Permalink
Browse files
[css-ui] Remove caret/progress-bar-value/listitem values from appeara…
…nce property

https://bugs.webkit.org/show_bug.cgi?id=240390

Reviewed by Aditya Keerthi.

LayoutTests/imported/w3c:

They're basically unimplemented.

* web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:

Source/WebCore:

Test: imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001.html

* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
* css/CSSValueKeywords.in:
* platform/ThemeTypes.cpp:
(WebCore::operator<<):
* platform/ThemeTypes.h:

LayoutTests:

They're basically unimplemented.

Remove WPE expectations which were very out-of-date.

* fast/css/appearance-with-pseudo-elements-expected.html:
* fast/css/appearance-with-pseudo-elements-in-quirks-mode-expected.html:
* fast/css/appearance-with-pseudo-elements-in-quirks-mode.html:
* fast/css/appearance-with-pseudo-elements.html:
* platform/gtk/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
* platform/ios-wk2/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
* platform/wpe/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt: Removed.

Canonical link: https://commits.webkit.org/250538@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294170 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
nt1m committed May 13, 2022
1 parent 8d214ae commit d4a075ec69dc769b7ce94f8b5cea956c3d7520e2
Show file tree
Hide file tree
Showing 15 changed files with 64 additions and 385 deletions.
@@ -1,3 +1,22 @@
2022-05-13 Tim Nguyen <ntim@apple.com>

[css-ui] Remove caret/progress-bar-value/listitem values from appearance property
https://bugs.webkit.org/show_bug.cgi?id=240390

Reviewed by Aditya Keerthi.

They're basically unimplemented.

Remove WPE expectations which were very out-of-date.

* fast/css/appearance-with-pseudo-elements-expected.html:
* fast/css/appearance-with-pseudo-elements-in-quirks-mode-expected.html:
* fast/css/appearance-with-pseudo-elements-in-quirks-mode.html:
* fast/css/appearance-with-pseudo-elements.html:
* platform/gtk/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
* platform/ios-wk2/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
* platform/wpe/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt: Removed.

2022-05-13 Anjali Kumar <anjalik_22@apple.com>

Web Inspector: [Meta] Implement Timelines Film Strip
@@ -12,7 +12,6 @@
}
#center::after {
content: "cappuccino";
-webkit-appearance: list-item;
}
</style>
<body>
@@ -11,7 +11,6 @@
}
#center:after {
content: "cappuccino";
-webkit-appearance: list-item;
}
</style>
<body>
@@ -11,7 +11,6 @@
}
#center:after {
content: "cappuccino";
-webkit-appearance: list-item;
}
</style>
<body>
@@ -12,7 +12,6 @@
}
#center::after {
content: "cappuccino";
-webkit-appearance: list-item;
}
</style>
<body>
@@ -1,3 +1,14 @@
2022-05-13 Tim Nguyen <ntim@apple.com>

[css-ui] Remove caret/progress-bar-value/listitem values from appearance property
https://bugs.webkit.org/show_bug.cgi?id=240390

Reviewed by Aditya Keerthi.

They're basically unimplemented.

* web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:

2022-05-13 Ziran Sun <zsun@igalia.com>

input.showPicker() should throw when input is readonly/disabled
@@ -26,7 +26,7 @@ PASS -webkit-appearance: button-arrow-previous (invalid)
PASS -webkit-appearance: button-arrow-up (invalid)
PASS -webkit-appearance: button-focus (invalid)
FAIL -webkit-appearance: caps-lock-indicator (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "caps-lock-indicator"
FAIL -webkit-appearance: caret (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "caret"
PASS -webkit-appearance: caret (invalid)
PASS -webkit-appearance: checkbox-container (invalid)
PASS -webkit-appearance: checkbox-label (invalid)
PASS -webkit-appearance: checkmenuitem (invalid)
@@ -39,7 +39,7 @@ PASS -webkit-appearance: groupbox (invalid)
PASS -webkit-appearance: image-controls-button (invalid)
FAIL -webkit-appearance: inner-spin-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "inner-spin-button"
FAIL -webkit-appearance: list-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "list-button"
FAIL -webkit-appearance: listitem (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "listitem"
PASS -webkit-appearance: listitem (invalid)
PASS -webkit-appearance: media-controls-background (invalid)
FAIL -webkit-appearance: media-controls-dark-bar-background (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-controls-dark-bar-background"
PASS -webkit-appearance: media-controls-fullscreen-background (invalid)
@@ -78,7 +78,7 @@ PASS -webkit-appearance: menuseparator (invalid)
PASS -webkit-appearance: meterbar (invalid)
PASS -webkit-appearance: meterchunk (invalid)
PASS -webkit-appearance: number-input (invalid)
FAIL -webkit-appearance: progress-bar-value (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "progress-bar-value"
PASS -webkit-appearance: progress-bar-value (invalid)
PASS -webkit-appearance: progressbar (invalid)
PASS -webkit-appearance: progressbar-vertical (invalid)
PASS -webkit-appearance: progresschunk (invalid)
@@ -189,7 +189,7 @@ PASS appearance: button-arrow-previous (invalid)
PASS appearance: button-arrow-up (invalid)
PASS appearance: button-focus (invalid)
FAIL appearance: caps-lock-indicator (invalid) assert_equals: style.appearance expected "" but got "caps-lock-indicator"
FAIL appearance: caret (invalid) assert_equals: style.appearance expected "" but got "caret"
PASS appearance: caret (invalid)
PASS appearance: checkbox-container (invalid)
PASS appearance: checkbox-label (invalid)
PASS appearance: checkmenuitem (invalid)
@@ -202,7 +202,7 @@ PASS appearance: groupbox (invalid)
PASS appearance: image-controls-button (invalid)
FAIL appearance: inner-spin-button (invalid) assert_equals: style.appearance expected "" but got "inner-spin-button"
FAIL appearance: list-button (invalid) assert_equals: style.appearance expected "" but got "list-button"
FAIL appearance: listitem (invalid) assert_equals: style.appearance expected "" but got "listitem"
PASS appearance: listitem (invalid)
PASS appearance: media-controls-background (invalid)
FAIL appearance: media-controls-dark-bar-background (invalid) assert_equals: style.appearance expected "" but got "media-controls-dark-bar-background"
PASS appearance: media-controls-fullscreen-background (invalid)
@@ -241,7 +241,7 @@ PASS appearance: menuseparator (invalid)
PASS appearance: meterbar (invalid)
PASS appearance: meterchunk (invalid)
PASS appearance: number-input (invalid)
FAIL appearance: progress-bar-value (invalid) assert_equals: style.appearance expected "" but got "progress-bar-value"
PASS appearance: progress-bar-value (invalid)
PASS appearance: progressbar (invalid)
PASS appearance: progressbar-vertical (invalid)
PASS appearance: progresschunk (invalid)
@@ -26,7 +26,7 @@ PASS -webkit-appearance: button-arrow-previous (invalid)
PASS -webkit-appearance: button-arrow-up (invalid)
PASS -webkit-appearance: button-focus (invalid)
FAIL -webkit-appearance: caps-lock-indicator (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "caps-lock-indicator"
FAIL -webkit-appearance: caret (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "caret"
PASS -webkit-appearance: caret (invalid)
PASS -webkit-appearance: checkbox-container (invalid)
PASS -webkit-appearance: checkbox-label (invalid)
PASS -webkit-appearance: checkmenuitem (invalid)
@@ -39,7 +39,7 @@ PASS -webkit-appearance: groupbox (invalid)
PASS -webkit-appearance: image-controls-button (invalid)
FAIL -webkit-appearance: inner-spin-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "inner-spin-button"
FAIL -webkit-appearance: list-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "list-button"
FAIL -webkit-appearance: listitem (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "listitem"
PASS -webkit-appearance: listitem (invalid)
PASS -webkit-appearance: media-controls-background (invalid)
FAIL -webkit-appearance: media-controls-dark-bar-background (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-controls-dark-bar-background"
PASS -webkit-appearance: media-controls-fullscreen-background (invalid)
@@ -78,7 +78,7 @@ PASS -webkit-appearance: menuseparator (invalid)
PASS -webkit-appearance: meterbar (invalid)
PASS -webkit-appearance: meterchunk (invalid)
PASS -webkit-appearance: number-input (invalid)
FAIL -webkit-appearance: progress-bar-value (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "progress-bar-value"
PASS -webkit-appearance: progress-bar-value (invalid)
PASS -webkit-appearance: progressbar (invalid)
PASS -webkit-appearance: progressbar-vertical (invalid)
PASS -webkit-appearance: progresschunk (invalid)
@@ -189,7 +189,7 @@ PASS appearance: button-arrow-previous (invalid)
PASS appearance: button-arrow-up (invalid)
PASS appearance: button-focus (invalid)
FAIL appearance: caps-lock-indicator (invalid) assert_equals: style.appearance expected "" but got "caps-lock-indicator"
FAIL appearance: caret (invalid) assert_equals: style.appearance expected "" but got "caret"
PASS appearance: caret (invalid)
PASS appearance: checkbox-container (invalid)
PASS appearance: checkbox-label (invalid)
PASS appearance: checkmenuitem (invalid)
@@ -202,7 +202,7 @@ PASS appearance: groupbox (invalid)
PASS appearance: image-controls-button (invalid)
FAIL appearance: inner-spin-button (invalid) assert_equals: style.appearance expected "" but got "inner-spin-button"
FAIL appearance: list-button (invalid) assert_equals: style.appearance expected "" but got "list-button"
FAIL appearance: listitem (invalid) assert_equals: style.appearance expected "" but got "listitem"
PASS appearance: listitem (invalid)
PASS appearance: media-controls-background (invalid)
FAIL appearance: media-controls-dark-bar-background (invalid) assert_equals: style.appearance expected "" but got "media-controls-dark-bar-background"
PASS appearance: media-controls-fullscreen-background (invalid)
@@ -241,7 +241,7 @@ PASS appearance: menuseparator (invalid)
PASS appearance: meterbar (invalid)
PASS appearance: meterchunk (invalid)
PASS appearance: number-input (invalid)
FAIL appearance: progress-bar-value (invalid) assert_equals: style.appearance expected "" but got "progress-bar-value"
PASS appearance: progress-bar-value (invalid)
PASS appearance: progressbar (invalid)
PASS appearance: progressbar-vertical (invalid)
PASS appearance: progresschunk (invalid)
@@ -26,7 +26,7 @@ PASS -webkit-appearance: button-arrow-previous (invalid)
PASS -webkit-appearance: button-arrow-up (invalid)
PASS -webkit-appearance: button-focus (invalid)
FAIL -webkit-appearance: caps-lock-indicator (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "caps-lock-indicator"
FAIL -webkit-appearance: caret (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "caret"
PASS -webkit-appearance: caret (invalid)
PASS -webkit-appearance: checkbox-container (invalid)
PASS -webkit-appearance: checkbox-label (invalid)
PASS -webkit-appearance: checkmenuitem (invalid)
@@ -39,7 +39,7 @@ PASS -webkit-appearance: groupbox (invalid)
PASS -webkit-appearance: image-controls-button (invalid)
FAIL -webkit-appearance: inner-spin-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "inner-spin-button"
FAIL -webkit-appearance: list-button (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "list-button"
FAIL -webkit-appearance: listitem (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "listitem"
PASS -webkit-appearance: listitem (invalid)
PASS -webkit-appearance: media-controls-background (invalid)
FAIL -webkit-appearance: media-controls-dark-bar-background (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "media-controls-dark-bar-background"
PASS -webkit-appearance: media-controls-fullscreen-background (invalid)
@@ -78,7 +78,7 @@ PASS -webkit-appearance: menuseparator (invalid)
PASS -webkit-appearance: meterbar (invalid)
PASS -webkit-appearance: meterchunk (invalid)
PASS -webkit-appearance: number-input (invalid)
FAIL -webkit-appearance: progress-bar-value (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "progress-bar-value"
PASS -webkit-appearance: progress-bar-value (invalid)
PASS -webkit-appearance: progressbar (invalid)
PASS -webkit-appearance: progressbar-vertical (invalid)
PASS -webkit-appearance: progresschunk (invalid)
@@ -189,7 +189,7 @@ PASS appearance: button-arrow-previous (invalid)
PASS appearance: button-arrow-up (invalid)
PASS appearance: button-focus (invalid)
FAIL appearance: caps-lock-indicator (invalid) assert_equals: style.appearance expected "" but got "caps-lock-indicator"
FAIL appearance: caret (invalid) assert_equals: style.appearance expected "" but got "caret"
PASS appearance: caret (invalid)
PASS appearance: checkbox-container (invalid)
PASS appearance: checkbox-label (invalid)
PASS appearance: checkmenuitem (invalid)
@@ -202,7 +202,7 @@ PASS appearance: groupbox (invalid)
PASS appearance: image-controls-button (invalid)
FAIL appearance: inner-spin-button (invalid) assert_equals: style.appearance expected "" but got "inner-spin-button"
FAIL appearance: list-button (invalid) assert_equals: style.appearance expected "" but got "list-button"
FAIL appearance: listitem (invalid) assert_equals: style.appearance expected "" but got "listitem"
PASS appearance: listitem (invalid)
PASS appearance: media-controls-background (invalid)
FAIL appearance: media-controls-dark-bar-background (invalid) assert_equals: style.appearance expected "" but got "media-controls-dark-bar-background"
PASS appearance: media-controls-fullscreen-background (invalid)
@@ -241,7 +241,7 @@ PASS appearance: menuseparator (invalid)
PASS appearance: meterbar (invalid)
PASS appearance: meterchunk (invalid)
PASS appearance: number-input (invalid)
FAIL appearance: progress-bar-value (invalid) assert_equals: style.appearance expected "" but got "progress-bar-value"
PASS appearance: progress-bar-value (invalid)
PASS appearance: progressbar (invalid)
PASS appearance: progressbar-vertical (invalid)
PASS appearance: progresschunk (invalid)

0 comments on commit d4a075e

Please sign in to comment.