Skip to content
Permalink
Browse files
Web Inspector: UIProcess ASSERT in ~RemoteWebInspectorProxy when Insp…
…ectorProcess crashes

https://bugs.webkit.org/show_bug.cgi?id=179044

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2017-10-31
Reviewed by Alex Christensen.

* UIProcess/RemoteWebInspectorProxy.cpp:
(WebKit::RemoteWebInspectorProxy::frontendDidClose):
Add a protector to keep the proxy alive for the duration of this method.

Canonical link: https://commits.webkit.org/195205@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224249 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
JosephPecoraro authored and webkit-commit-queue committed Oct 31, 2017
1 parent ec2ca3d commit d7215be0b9a0ef2d07e032c902595cc1597af768
Showing 2 changed files with 13 additions and 0 deletions.
@@ -1,3 +1,14 @@
2017-10-31 Joseph Pecoraro <pecoraro@apple.com>

Web Inspector: UIProcess ASSERT in ~RemoteWebInspectorProxy when InspectorProcess crashes
https://bugs.webkit.org/show_bug.cgi?id=179044

Reviewed by Alex Christensen.

* UIProcess/RemoteWebInspectorProxy.cpp:
(WebKit::RemoteWebInspectorProxy::frontendDidClose):
Add a protector to keep the proxy alive for the duration of this method.

2017-10-31 Youenn Fablet <youenn@apple.com>

Crash in: com.apple.WebKit: WebKit::CacheStorage::Caches::initializeSize(WTF::Function<void (std::optional<WebCore::DOMCacheEngine::Error>&&)>&&) + 30 (CacheStorageEngineCaches.cpp:163)
@@ -82,6 +82,8 @@ void RemoteWebInspectorProxy::sendMessageToFrontend(const String& message)

void RemoteWebInspectorProxy::frontendDidClose()
{
Ref<RemoteWebInspectorProxy> protect(*this);

if (m_client)
m_client->closeFromFrontend();

0 comments on commit d7215be

Please sign in to comment.