Skip to content
Permalink
Browse files
[GTK] Build failures when building with python 3.3
https://bugs.webkit.org/show_bug.cgi?id=106194

Reviewed by Dirk Pranke.

Python 3.3 introduced changes to dictionaries which can result in changed
iteration order. More about these changes:
http://docs.python.org/3.3/whatsnew/3.3.html#pep-412-key-sharing-dictionary
http://www.python.org/dev/peps/pep-0412/#cons

This causes the Source/WebCore/inspector/generate-inspector-protocol-version
script to fail the self-testing when using Python 3.3. These changes work
around this problem by not checking for expected errors in order but rather
for their presence in the error output sequence. The number of actual errors
is also checked to be equal to the number of expected errors.

No new tests - no new functionality.

* inspector/generate-inspector-protocol-version:
(self_test):


Canonical link: https://commits.webkit.org/124537@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139081 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
zdobersek committed Jan 8, 2013
1 parent 043f606 commit d78935a37403929e68cad7fff9ede05782285dd5
Showing 2 changed files with 25 additions and 2 deletions.
@@ -1,3 +1,26 @@
2013-01-08 Zan Dobersek <zandobersek@gmail.com>

[GTK] Build failures when building with python 3.3
https://bugs.webkit.org/show_bug.cgi?id=106194

Reviewed by Dirk Pranke.

Python 3.3 introduced changes to dictionaries which can result in changed
iteration order. More about these changes:
http://docs.python.org/3.3/whatsnew/3.3.html#pep-412-key-sharing-dictionary
http://www.python.org/dev/peps/pep-0412/#cons

This causes the Source/WebCore/inspector/generate-inspector-protocol-version
script to fail the self-testing when using Python 3.3. These changes work
around this problem by not checking for expected errors in order but rather
for their presence in the error output sequence. The number of actual errors
is also checked to be equal to the number of expected errors.

No new tests - no new functionality.

* inspector/generate-inspector-protocol-version:
(self_test):

2013-01-08 Antoine Quint <graouts@apple.com>

<track> element's mode set to "disabled" after load although it was explicitly set to "hidden"
@@ -303,9 +303,9 @@ def self_test():
"Network.requestWillBeSent: required parameter is missing: postData",
"Network.requestWillBeSent: required parameter is missing: documentURL" ]
for i in range(len(errors)):
if errors[i] != golden_errors[i]:
if errors[i] not in golden_errors:
return False
return True
return len(errors) is len(golden_errors)

def main():
if not self_test():

0 comments on commit d78935a

Please sign in to comment.