Skip to content
Permalink
Browse files
Fixes a bug where while editing in the Inspector the
        sidebar scroll position would jump to the top.

        https://bugs.webkit.org/show_bug.cgi?id=20484

        Reviewed by Darin Adler.

        * page/inspector/treeoutline.js:
        (TreeOutline._removeChildren): Remove the offsetTop call that
        was forcing a layout, since layout causes scroll positions
        to be clamped to the new scrollHeight/Width. Layout will happen
        normally when needed.

Canonical link: https://commits.webkit.org/28297@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35891 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
xeenon committed Aug 22, 2008
1 parent 0478e60 commit d8744ad0b3f77a362e2f0735bf9da0e571903078
Showing 2 changed files with 15 additions and 3 deletions.
@@ -1,3 +1,18 @@
2008-08-22 Timothy Hatcher <timothy@apple.com>

Fixes a bug where while editing in the Inspector the
sidebar scroll position would jump to the top.

https://bugs.webkit.org/show_bug.cgi?id=20484

Reviewed by Darin Adler.

* page/inspector/treeoutline.js:
(TreeOutline._removeChildren): Remove the offsetTop call that
was forcing a layout, since layout causes scroll positions
to be clamped to the new scrollHeight/Width. Layout will happen
normally when needed.

2008-08-22 Kevin Ollivier <kevino@theolliviers.com>

wx build fix. Add AccessibilityTable sources.
@@ -184,9 +184,6 @@ TreeOutline._removeChildren = function()
}

this.children = [];

if (this._childrenListNode)
this._childrenListNode.offsetTop; // force layout
}

TreeOutline._removeChildrenRecursive = function()

0 comments on commit d8744ad

Please sign in to comment.