Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
REGRESSION(r282115): undefined reference to `IPC::messageArgumentDesc…
…riptions(IPC::MessageName)' in Debug build

https://bugs.webkit.org/show_bug.cgi?id=230064

Unreviewed build fix.

Debug build of non-Cocoa ports were broken since r282115 started
to use IPC::messageArgumentDescriptions for debug logging.
However, MessageArgumentDescriptions.cpp has a long-standing
compilation problem for non-Cocoa ports.

Temporarily disabled the debug logging for non-Cocoa ports by
using ENABLE(IPC_TESTING_API) macro. I'll revert this change after
I will fix the fundamental problem of messages.py.

* Platform/IPC/HandleMessage.h:
(IPC::logMessageImpl):
(IPC::logReply):

Canonical link: https://commits.webkit.org/241469@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@282177 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
fujii committed Sep 8, 2021
1 parent 4e4a100 commit d8ef94e
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 3 deletions.
20 changes: 20 additions & 0 deletions Source/WebKit/ChangeLog
@@ -1,3 +1,23 @@
2021-09-08 Fujii Hironori <Hironori.Fujii@sony.com>

REGRESSION(r282115): undefined reference to `IPC::messageArgumentDescriptions(IPC::MessageName)' in Debug build
https://bugs.webkit.org/show_bug.cgi?id=230064

Unreviewed build fix.

Debug build of non-Cocoa ports were broken since r282115 started
to use IPC::messageArgumentDescriptions for debug logging.
However, MessageArgumentDescriptions.cpp has a long-standing
compilation problem for non-Cocoa ports.

Temporarily disabled the debug logging for non-Cocoa ports by
using ENABLE(IPC_TESTING_API) macro. I'll revert this change after
I will fix the fundamental problem of messages.py.

* Platform/IPC/HandleMessage.h:
(IPC::logMessageImpl):
(IPC::logReply):

2021-09-08 Sihui Liu <sihui_liu@apple.com>

Remove unnecessary WTF:: in WebsiteDataStore files
Expand Down
6 changes: 3 additions & 3 deletions Source/WebKit/Platform/IPC/HandleMessage.h
Expand Up @@ -47,7 +47,7 @@ class Connection;

constexpr unsigned loggingContainerSizeLimit = 200;

#if !LOG_DISABLED
#if !LOG_DISABLED && ENABLE(IPC_TESTING_API)
enum class ForReply : bool { No, Yes };

inline TextStream textStreamForLogging(const Connection& connection, MessageName messageName, ForReply forReply)
Expand All @@ -73,7 +73,7 @@ inline TextStream textStreamForLogging(const Connection& connection, MessageName
template<typename ArgsTuple, size_t... ArgsIndex>
void logMessageImpl(const Connection& connection, MessageName messageName, const ArgsTuple& args, std::index_sequence<ArgsIndex...>)
{
#if !LOG_DISABLED
#if !LOG_DISABLED && ENABLE(IPC_TESTING_API)
auto stream = textStreamForLogging(connection, messageName, ForReply::No);

if (auto argumentDescriptions = messageArgumentDescriptions(messageName))
Expand All @@ -96,7 +96,7 @@ void logMessage(const Connection& connection, MessageName messageName, const Arg
template<typename... T>
void logReply(const Connection& connection, MessageName messageName, const T&... args)
{
#if !LOG_DISABLED
#if !LOG_DISABLED && ENABLE(IPC_TESTING_API)
if (!sizeof...(T))
return;

Expand Down

0 comments on commit d8ef94e

Please sign in to comment.