Skip to content
Permalink
Browse files
Remove redundant text-indent tests already covered by WPT
https://bugs.webkit.org/show_bug.cgi?id=240730

Patch by Kiet Ho <tho22@apple.com> on 2022-05-20
Reviewed by Simon Fraser.

getComputedStyle-text-indent.html is covered by the following WPT tests:
  * LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/text-indent-computed.html
  * LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/text-indent-invalid.html
  * LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/text-indent-valid.html

getComputedStyle-text-indent-inherited.html is covered by the WPT test
LayoutTests/imported/w3c/web-platform-tests/css/css-text/inheritance.html

They are also obsolete, since they still use the prefixed keywords '-webkit-each-line' and
'-webkit-hanging', while WebKit has supported the non-prefixed keywords since
https://bugs.webkit.org/show_bug.cgi?id=223851. They were also marked as skipped since a long
time ago. Therefore there's no reason not to remove them.

* LayoutTests/TestExpectations:
* LayoutTests/fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent-expected.txt: Removed.
* LayoutTests/fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent-inherited-expected.txt: Removed.
* LayoutTests/fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent-inherited.html: Removed.
* LayoutTests/fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent.html: Removed.

Canonical link: https://commits.webkit.org/250815@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294578 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
tuankiet65 authored and webkit-commit-queue committed May 20, 2022
1 parent b8c7704 commit d9f38164b3d65a6c96697289e330b0189b9ae8eb
Showing 5 changed files with 0 additions and 484 deletions.
@@ -2911,7 +2911,6 @@ imported/w3c/web-platform-tests/secure-contexts/basic-popup-and-iframe-tests.htt
webkit.org/b/76173 fast/css3-text/css3-text-align-last [ Skip ]
webkit.org/b/99945 fast/css3-text/css3-text-justify [ Skip ]
webkit.org/b/112755 fast/css3-text/css3-text-indent/text-indent-each-line-hanging.html [ Skip ]
webkit.org/b/112755 fast/css3-text/css3-text-indent/getComputedStyle [ Skip ]

# Link prefetch is disabled by default (needs ENABLE_LINK_PREFETCH)
webkit.org/b/3652 fast/dom/HTMLLinkElement/link-and-subresource-test.html [ Skip ]

This file was deleted.

This file was deleted.

This file was deleted.

0 comments on commit d9f3816

Please sign in to comment.