This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
AX: Don't create isolated objects from ignored live objects
https://bugs.webkit.org/show_bug.cgi?id=240507 Reviewed by Chris Fleizach. Sometimes, we can get into a state where a live object has dynamically become ignored but not removed as a child from its parent (since unignored objects are the only thing that should be in any AccessibilityObject::m_children). This can cause us to create an isolated object for this ignored live object. With this change, we now return a std::nullopt NodeChange for an ignored live object. I split this change off from a different patch improving our handling of modals. It is required to make accessibility/aria-modal-multiple-dialogs.html pass in isolated tree mode. * Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp: (WebCore::AXIsolatedTree::nodeChangeForObject): (WebCore::AXIsolatedTree::queueRemovalsAndUnresolvedChanges): (WebCore::AXIsolatedTree::updateNode): * Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h: Canonical link: https://commits.webkit.org/251017@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294894 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- Loading branch information
Showing 2 changed files with 16 additions and 10 deletions.