Skip to content
Permalink
Browse files
fast/css/hover-update.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=111592

Reviewed by Ryosuke Niwa.

Speculative fix for a flaky test. The test sometimes fails on slower machines (mostly debug).
Re-check the results in a loop for up to 200ms to see if the :hover pseudo style applies.

Also force a layout after changing the style, which should also trigger the :hover style.

* fast/css/hover-update.html:
* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:


Canonical link: https://commits.webkit.org/129977@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144963 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
idealisms committed Mar 6, 2013
1 parent 388713e commit db6dfc6db6a3faf47d29783f8ac66290f1b631fe
Showing 6 changed files with 29 additions and 9 deletions.
@@ -1,3 +1,21 @@
2013-03-06 Tony Chang <tony@chromium.org>

fast/css/hover-update.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=111592

Reviewed by Ryosuke Niwa.

Speculative fix for a flaky test. The test sometimes fails on slower machines (mostly debug).
Re-check the results in a loop for up to 200ms to see if the :hover pseudo style applies.

Also force a layout after changing the style, which should also trigger the :hover style.

* fast/css/hover-update.html:
* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:

2013-03-06 Rafael Weinstein <rafaelw@chromium.org>

Unreviewed gardening: svg/custom/foreign-object-skew.svg
@@ -21,7 +21,14 @@
<script type="text/javascript">
function finish()
{
shouldBeEqualToString("window.getComputedStyle(document.getElementById('b'), null).backgroundColor", "rgb(0, 128, 0)");
var expectedBackgroundColor = "rgb(0, 128, 0)";
// This test was failing on slower machines, so we give it more time to try to apply the hover state.
var timeSinceStartedCheckingMs = Date.now() - window.startCheckingForHoverMs;
if (timeSinceStartedCheckingMs < 200 && getComputedStyle(document.getElementById('b')).backgroundColor != expectedBackgroundColor) {
setTimeout(finish, 10);
return;
}
shouldBeEqualToString("window.getComputedStyle(document.getElementById('b'), null).backgroundColor", expectedBackgroundColor);

if (window.testRunner)
testRunner.notifyDone();
@@ -30,6 +37,8 @@
function hideC()
{
c.style.display = 'none';
document.body.offsetLeft;
window.startCheckingForHoverMs = Date.now();
window.setTimeout(finish, 0);
}

@@ -43,7 +52,7 @@
if (!window.testRunner)
return;

debug('Hover color before test: ' + window.getComputedStyle(document.getElementById("b"), null).backgroundColor);
debug('Hover color before test: ' + getComputedStyle(document.getElementById("b")).backgroundColor);

testRunner.waitUntilDone();
var target = document.getElementById('target');
@@ -3431,8 +3431,6 @@ webkit.org/b/85689 fast/animation/request-animation-frame-disabled.html [ Skip ]
# Skip it because it seems its frame loading notifications leak to the next test.
webkit.org/b/85949 http/tests/loading/post-in-iframe-with-back-navigation.html [ Skip ]

webkit.org/b/85951 [ Win Debug ] fast/css/hover-update.html [ Failure Pass ]

# Requires ENABLE(MEDIA_CAPTURE)
webkit.org/b/85958 fast/forms/file/file-input-capture.html [ Failure ]

@@ -1610,7 +1610,6 @@ Bug(EFL) editing/selection/caret-ltr.html [ Failure Pass ]
Bug(EFL) editing/selection/caret-ltr-2-left.html [ Failure Pass ]
Bug(EFL) editing/selection/caret-ltr-2.html [ Failure Pass ]
Bug(EFL) editing/selection/caret-rtl-2.html [ Failure Pass ]
Bug(EFL) fast/css/hover-update.html [ Failure Pass ]
Bug(EFL) fast/dynamic/012.html [ Failure ]
Bug(EFL) fast/dynamic/layer-hit-test-crash.html [ Failure ]
Bug(EFL) fast/layers/layer-visibility-sublayer.html [ Failure ]
@@ -523,8 +523,6 @@ webkit.org/b/76385 tables/mozilla_expected_failures/marvin/table_overflow_dirty_

webkit.org/b/78344 fast/text/international/inline-plaintext-relayout-with-leading-neutrals.html [ ImageOnlyFailure Pass ]

webkit.org/b/80246 fast/css/hover-update.html [ Failure Pass ]

webkit.org/b/86971 svg/custom/non-scaling-stroke-markers.svg [ Failure Pass ]

webkit.org/b/89650 [ Debug ] svg/W3C-SVG-1.1/animate-elem-05-t.svg [ Failure Pass ]
@@ -1436,5 +1436,3 @@ webkit.org/b/110654 css3/flexbox/button.html [ Failure ]
webkit.org/b/111016 http/tests/loading/promote-img-preload-priority.html [ Failure ]

webkit.org/b/111521 editing/selection/selection-invalid-offset.html [ Crash Pass ]

webkit.org/b/111592 fast/css/hover-update.html [ Failure Pass ]

0 comments on commit db6dfc6

Please sign in to comment.