Skip to content
Permalink
Browse files
Implement WebFrame::startDownload
        Fixes the WebKit side of Bug 25729: Alt-clicking a link doesn't start
        a download <https://bugs.webkit.org/show_bug.cgi?id=25729>. Fixing
        this all the way will require a change in Safari.

        Reviewed by Darin Adler.

        * WebFrame.cpp:
        (WebFrame::startDownload): Call through to WebView::downloadURL.

Canonical link: https://commits.webkit.org/36109@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44273 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
aroben committed May 29, 2009
1 parent 870440a commit dc2a6536e1b1f9c38a4ea19242558457d4462de2
Showing 2 changed files with 15 additions and 2 deletions.
@@ -1,3 +1,16 @@
2009-05-29 Adam Roben <aroben@apple.com>

Implement WebFrame::startDownload

Fixes the WebKit side of Bug 25729: Alt-clicking a link doesn't start
a download <https://bugs.webkit.org/show_bug.cgi?id=25729>. Fixing
this all the way will require a change in Safari.

Reviewed by Darin Adler.

* WebFrame.cpp:
(WebFrame::startDownload): Call through to WebView::downloadURL.

2009-05-29 Adam Roben <aroben@apple.com>

Move WebContextMenuClient's downloading code to WebView
@@ -1605,9 +1605,9 @@ void WebFrame::dispatchDidFailLoad(const ResourceError& error)
}
}

void WebFrame::startDownload(const ResourceRequest&)
void WebFrame::startDownload(const ResourceRequest& request)
{
notImplemented();
d->webView->downloadURL(request.url());
}

Widget* WebFrame::createJavaAppletWidget(const IntSize& pluginSize, HTMLAppletElement* element, const KURL& /*baseURL*/, const Vector<String>& paramNames, const Vector<String>& paramValues)

0 comments on commit dc2a653

Please sign in to comment.