Web Automation: suppress automatic text correction in pages controlle…

…d by automation

https://bugs.webkit.org/show_bug.cgi?id=156599
<rdar://problem/25712646>

Reviewed by Timothy Hatcher.

If the page is controlled by automation, then automatic text corrections will
cause unexpected behaviors by nondeterministically modifying text inserted by
a test. Just pretend these behaviors are disabled if controlled by automation.

* WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
(WebKit::WebEditorClient::isAutomaticQuoteSubstitutionEnabled):
(WebKit::WebEditorClient::isAutomaticDashSubstitutionEnabled):
(WebKit::WebEditorClient::isAutomaticTextReplacementEnabled):
(WebKit::WebEditorClient::isAutomaticSpellingCorrectionEnabled):


Canonical link: https://commits.webkit.org/174705@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@199565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit2/ChangeLog

@@ -1,3 +1,21 @@
+2016-04-14  Brian Burg  <bburg@apple.com>
+
+        Web Automation: suppress automatic text correction in pages controlled by automation
+        https://bugs.webkit.org/show_bug.cgi?id=156599
+        <rdar://problem/25712646>
+
+        Reviewed by Timothy Hatcher.
+
+        If the page is controlled by automation, then automatic text corrections will
+        cause unexpected behaviors by nondeterministically modifying text inserted by
+        a test. Just pretend these behaviors are disabled if controlled by automation.
+
+        * WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
+        (WebKit::WebEditorClient::isAutomaticQuoteSubstitutionEnabled):
+        (WebKit::WebEditorClient::isAutomaticDashSubstitutionEnabled):
+        (WebKit::WebEditorClient::isAutomaticTextReplacementEnabled):
+        (WebKit::WebEditorClient::isAutomaticSpellingCorrectionEnabled):
+
 2016-04-14  Anders Carlsson  <andersca@apple.com>
 
         Try to fix the Yosemite build.

Source/WebKit2/WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm

@@ -185,6 +185,9 @@ static void changeWordCase(WebPage* page, SEL selector)
 
 bool WebEditorClient::isAutomaticQuoteSubstitutionEnabled()
 {
+    if (m_page->isControlledByAutomation())
+        return false;
+
     return WebProcess::singleton().textCheckerState().isAutomaticQuoteSubstitutionEnabled;
 }
 
@@ -207,6 +210,9 @@ static void changeWordCase(WebPage* page, SEL selector)
 
 bool WebEditorClient::isAutomaticDashSubstitutionEnabled()
 {
+    if (m_page->isControlledByAutomation())
+        return false;
+
     return WebProcess::singleton().textCheckerState().isAutomaticDashSubstitutionEnabled;
 }
 
@@ -218,6 +224,9 @@ static void changeWordCase(WebPage* page, SEL selector)
 
 bool WebEditorClient::isAutomaticTextReplacementEnabled()
 {
+    if (m_page->isControlledByAutomation())
+        return false;
+
     return WebProcess::singleton().textCheckerState().isAutomaticTextReplacementEnabled;
 }
 
@@ -229,6 +238,9 @@ static void changeWordCase(WebPage* page, SEL selector)
 
 bool WebEditorClient::isAutomaticSpellingCorrectionEnabled()
 {
+    if (m_page->isControlledByAutomation())
+        return false;
+
     return WebProcess::singleton().textCheckerState().isAutomaticSpellingCorrectionEnabled;
 }