Skip to content
Permalink
Browse files
Canvas blending tests fail on Mac WK2
https://bugs.webkit.org/show_bug.cgi?id=105943

Patch by Rik Cabanier <cabanier@adobe.com> on 2013-01-03
Reviewed by Simon Fraser.

Source/WebCore:

Tests that now pass:
    LayoutTests/fast/canvas/canvas-blend-solid.html
    LayoutTests/fast/canvas/canvas-blend-image.html

* testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
* testing/InternalSettings.h:
(Backup):

Source/WebKit2:

CanvasUsesAcceleratedDrawing preference was not passed to the WebProcess.

* WebProcess/InjectedBundle/InjectedBundle.cpp: Adds support for CanvasUsesAcceleratedDrawing to WK2
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

LayoutTests:

* platform/mac-wk2/TestExpectations: updated expectations as the test now passes

Canonical link: https://commits.webkit.org/124205@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138726 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
Rik Cabanier authored and webkit-commit-queue committed Jan 3, 2013
1 parent ae7100d commit ddaa8dc4404c57c4042df78a7488efd64af86cac
Showing 7 changed files with 42 additions and 4 deletions.
@@ -1,3 +1,12 @@
2013-01-03 Rik Cabanier <cabanier@adobe.com>

Canvas blending tests fail on Mac WK2
https://bugs.webkit.org/show_bug.cgi?id=105943

Reviewed by Simon Fraser.

* platform/mac-wk2/TestExpectations: updated expectations as the test now passes

2013-01-03 Adam Klein <adamk@chromium.org>

Clear failed image loads when an <img> is adopted into a different document
@@ -272,10 +272,6 @@ webkit.org/b/98960 fast/parser/document-open-in-unload.html [ Skip ]
webkit.org/b/76359 editing/shadow [ Skip ]
webkit.org/b/76359 fast/dom/shadow [ Skip ]

# Canvas blending tests fail on Mac WK2
webkit.org/b/105943 fast/canvas/canvas-blend-image.html [ Failure ]
webkit.org/b/105943 fast/canvas/canvas-blend-solid.html [ Failure ]

# fast/events/controlclick-no-onclick.html fails on Mac WK2
webkit.org/b/105948 fast/events/controlclick-no-onclick.html [ Failure ]

@@ -1,3 +1,20 @@
2013-01-03 Rik Cabanier <cabanier@adobe.com>

Canvas blending tests fail on Mac WK2
https://bugs.webkit.org/show_bug.cgi?id=105943

Reviewed by Simon Fraser.

Tests that now pass:
LayoutTests/fast/canvas/canvas-blend-solid.html
LayoutTests/fast/canvas/canvas-blend-image.html

* testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
* testing/InternalSettings.h:
(Backup):

2013-01-03 Arko Saha <arko@motorola.com>

Microdata: Fix build failure after r137003
@@ -95,6 +95,7 @@ InternalSettings::Backup::Backup(Settings* settings)
, m_originalCompositingForFixedPositionEnabled(settings->acceleratedCompositingForFixedPositionEnabled())
, m_originalCompositingForScrollableFramesEnabled(settings->acceleratedCompositingForScrollableFramesEnabled())
, m_originalAcceleratedDrawingEnabled(settings->acceleratedDrawingEnabled())
, m_originalCanvasUsesAcceleratedDrawing(settings->canvasUsesAcceleratedDrawing())
, m_originalMockScrollbarsEnabled(settings->mockScrollbarsEnabled())
, m_langAttributeAwareFormControlUIEnabled(RuntimeEnabledFeatures::langAttributeAwareFormControlUIEnabled())
, m_imagesEnabled(settings->areImagesEnabled())
@@ -141,6 +142,7 @@ void InternalSettings::Backup::restoreTo(Settings* settings)
settings->setAcceleratedCompositingForFixedPositionEnabled(m_originalCompositingForFixedPositionEnabled);
settings->setAcceleratedCompositingForScrollableFramesEnabled(m_originalCompositingForScrollableFramesEnabled);
settings->setAcceleratedDrawingEnabled(m_originalAcceleratedDrawingEnabled);
settings->setCanvasUsesAcceleratedDrawing(m_originalCanvasUsesAcceleratedDrawing);
settings->setMockScrollbarsEnabled(m_originalMockScrollbarsEnabled);
RuntimeEnabledFeatures::setLangAttributeAwareFormControlUIEnabled(m_langAttributeAwareFormControlUIEnabled);
settings->setImagesEnabled(m_imagesEnabled);
@@ -82,6 +82,7 @@ class InternalSettings : public RefCountedSupplement<Page, InternalSettings> {
bool m_originalCompositingForFixedPositionEnabled;
bool m_originalCompositingForScrollableFramesEnabled;
bool m_originalAcceleratedDrawingEnabled;
bool m_originalCanvasUsesAcceleratedDrawing;
bool m_originalMockScrollbarsEnabled;
bool m_originalUsesOverlayScrollbars;
bool m_langAttributeAwareFormControlUIEnabled;
@@ -1,3 +1,15 @@
2013-01-03 Rik Cabanier <cabanier@adobe.com>

Canvas blending tests fail on Mac WK2
https://bugs.webkit.org/show_bug.cgi?id=105943

Reviewed by Simon Fraser.

CanvasUsesAcceleratedDrawing preference was not passed to the WebProcess.

* WebProcess/InjectedBundle/InjectedBundle.cpp: Adds support for CanvasUsesAcceleratedDrawing to WK2
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

2013-01-02 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>

[Qt] Use WebPageProxy::postMessageToInjectedBundle when passing messages to a specific page in the builtin bundle
@@ -201,6 +201,7 @@ void InjectedBundle::overrideBoolPreferenceForTestRunner(WebPageGroupProxy* page
// Map the names used in LayoutTests with the names used in WebCore::Settings and WebPreferencesStore.
#define FOR_EACH_OVERRIDE_BOOL_PREFERENCE(macro) \
macro(WebKitAcceleratedCompositingEnabled, AcceleratedCompositingEnabled, acceleratedCompositingEnabled) \
macro(WebKitCanvasUsesAcceleratedDrawing, CanvasUsesAcceleratedDrawing, canvasUsesAcceleratedDrawing) \
macro(WebKitCSSCustomFilterEnabled, CSSCustomFilterEnabled, cssCustomFilterEnabled) \
macro(WebKitCSSGridLayoutEnabled, CSSGridLayoutEnabled, cssGridLayoutEnabled) \
macro(WebKitJavaEnabled, JavaEnabled, javaEnabled) \

0 comments on commit ddaa8dc

Please sign in to comment.