Skip to content
Permalink
Browse files
WebCore:
2008-10-22  Brent Fulgham  <bfulgham@gmail.com>

        Correct build regressions in Cairo port for Windows.
        http://bugs.webkit.org/show_bug.cgi?id=21724

        Reviewed by Adam Roben.

        * WebCore.vcproj/WebCore.vcproj:  Fixed include paths and post-build event for the Debug_Cairo and Release_Cairo configurations.
        * platform/graphics/win/GraphicsContextCairoWin.cpp:
        (WebCore::GraphicsContext::GraphicsContext): Update to newer constructor signature.
        * platform/network/curl/DNSCurl.cpp: Added.
        (WebCore::prefetchDNS):
        * platform/network/curl/ResourceRequest.h:
        * platform/win/ScrollbarThemeWin.cpp:
        (WebCore::ScrollbarTheme::nativeTheme):

WebKit/win:

2008-10-22  Brent Fulgham  <bfulgham@gmail.com>

        Correct build regressions in Cairo port for Windows.
        http://bugs.webkit.org/show_bug.cgi?id=21724

        Reviewed by Adam Roben.

        * WebView.cpp:
        (WebView::notifyPreferencesChanged): Don't try to call
        setShouldPaintNativeControls when SafariTheme support is disabled, as
        that function doesn't exist in that case.

Canonical link: https://commits.webkit.org/30021@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37797 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
aroben committed Oct 22, 2008
1 parent 7cab111 commit ddf6b573bfe56c70b79dc669ae55ee12d5a9b0a1
Showing 8 changed files with 142 additions and 19 deletions.
@@ -1,3 +1,13 @@
2008-10-22 Brent Fulgham <bfulgham@gmail.com>

http://bugs.webkit.org/show_bug.cgi?id=21812.
Bring Windows Cairo Port's font handling in line with CG.

Reviewed by David Hyatt.

* platform/graphics/win/FontCacheWin.cpp:
(WebCore::createGDIFont): Remove unnecessary special-case for Cairo TrueType font search. It should match CG in all font selections.

2008-10-22 Brady Eidson <beidson@apple.com>

Reviewed by Adam Roben

Large diffs are not rendered by default.

@@ -37,7 +37,7 @@ using namespace std;

namespace WebCore {

GraphicsContext::GraphicsContext(HDC dc)
GraphicsContext::GraphicsContext(HDC dc, bool hasAlpha)
: m_common(createGraphicsContextPrivate())
, m_data(new GraphicsContextPlatformPrivate)
{
@@ -0,0 +1,38 @@
/*
* Copyright (C) 2008 Apple Computer, Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution.
*
* THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY
* EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
* PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR
* CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
* EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
* PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
* PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
* OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/

#include "config.h"
#include "DNS.h"

#include "NotImplemented.h"

namespace WebCore {

void prefetchDNS(const String& hostname)
{
notImplemented();
}

}
@@ -29,6 +29,8 @@

#include "ResourceRequestBase.h"

typedef const void* CFURLRequestRef;

namespace WebCore {

struct ResourceRequest : ResourceRequestBase {
@@ -54,6 +56,9 @@ namespace WebCore {
{
}

// Needed for compatibility.
CFURLRequestRef cfURLRequest() const { return 0; }

private:
friend class ResourceRequestBase;

@@ -98,7 +98,7 @@ static void checkAndInitScrollbarTheme()
#if !USE(SAFARI_THEME)
ScrollbarTheme* ScrollbarTheme::nativeTheme()
{
static SafariThemeWin winTheme;
static ScrollbarThemeWin winTheme;
return &winTheme;
}
#endif
@@ -1,3 +1,15 @@
2008-10-22 Brent Fulgham <bfulgham@gmail.com>

Correct build regressions in Cairo port for Windows.
http://bugs.webkit.org/show_bug.cgi?id=21724

Reviewed by Adam Roben.

* WebView.cpp:
(WebView::notifyPreferencesChanged): Don't try to call
setShouldPaintNativeControls when SafariTheme support is disabled, as
that function doesn't exist in that case.

2008-10-22 Brady Eidson <beidson@apple.com>

Reviewed by Adam Roben
@@ -4148,10 +4148,12 @@ HRESULT WebView::notifyPreferencesChanged(IWebNotification* notification)
return hr;
settings->setOfflineWebApplicationCacheEnabled(enabled);

#if USE(SAFARI_THEME)
hr = prefsPrivate->shouldPaintNativeControls(&enabled);
if (FAILED(hr))
return hr;
settings->setShouldPaintNativeControls(!!enabled);
#endif

if (!m_closeWindowTimer.isActive())
m_mainFrame->invalidate(); // FIXME

0 comments on commit ddf6b57

Please sign in to comment.