Skip to content
Permalink
Browse files
Tests with an '-e' parameters in requireOptions fail with bytecode ca…
…che enabled

https://bugs.webkit.org/show_bug.cgi?id=218703

Patch by Xan López <xan@igalia.com> on 2022-05-19
Reviewed by Yusuke Suzuki.

Do not try to further tokenize the command parameters to the test run
in the bytecode cache helper script. This will just mess up things
like the '-e "foo bar"' extra options, and it's not needed.

* Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: do not tokenize the arguments to the script.
* Scripts/run-jsc-stress-tests: also run the bytecode cache tests on MIPS.

Canonical link: https://commits.webkit.org/250787@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294532 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
xanlpz authored and webkit-commit-queue committed May 20, 2022
1 parent a4adc3e commit df5c013e2487af7246537178c468b129275cedbd
Showing 2 changed files with 3 additions and 5 deletions.
@@ -25,17 +25,16 @@ set -e

mysys() {
set +e
eval "$*"
"$@"
exitCode=$?
if [ $exitCode != 0 ]; then
echo "Command '$*' failed"
echo "Command '$@' failed"
exit $exitCode
fi
}

fileTemplate=$1
shift
rest="$@"

diskCachePath=$(mktemp -d -t "$fileTemplate")

@@ -1004,8 +1004,7 @@ end
def bytecodeCacheTemplate
if ($hostOS == "darwin")
return "bytecode-cache"
elsif ($hostOS == "linux" && $architecture != "mips")
# FIXME: need to fix https://bugs.webkit.org/show_bug.cgi?id=218703 to enable this on Linux/MIPS.
elsif ($hostOS == "linux")
return "bytecode-cacheXXXXXX"
end
nil

0 comments on commit df5c013

Please sign in to comment.