Skip to content

Commit

Permalink
Remove support for running safari on the iOS simulator with Xcode < 9.0
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=178203

Patch by Frederic Wang <fwang@igalia.com> on 2017-10-12
Reviewed by Alexey Proskuryakov.

This is a follow-up of r223234. We no longer support iOS WebKit development for Xcode < 9.0
and do not have any iOS simulator builders in our infrastructure. Hence we can remove the
special case to calculate the iOS simulator applications path for these old versions.

* Scripts/webkitdirs.pm:
(iosSimulatorApplicationsPath): Remove special case for XCode < 9.0

Canonical link: https://commits.webkit.org/195145@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224180 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
fred-wang committed Oct 30, 2017
1 parent 95719c3 commit e200c1a
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 5 deletions.
14 changes: 14 additions & 0 deletions Tools/ChangeLog
@@ -1,3 +1,17 @@
2017-10-12 Frederic Wang <fwang@igalia.com>

Remove support for running safari on the iOS simulator with Xcode < 9.0
https://bugs.webkit.org/show_bug.cgi?id=178203

Reviewed by Alexey Proskuryakov.

This is a follow-up of r223234. We no longer support iOS WebKit development for Xcode < 9.0
and do not have any iOS simulator builders in our infrastructure. Hence we can remove the
special case to calculate the iOS simulator applications path for these old versions.

* Scripts/webkitdirs.pm:
(iosSimulatorApplicationsPath): Remove special case for XCode < 9.0

2017-10-30 Michael Catanzaro <mcatanzaro@igalia.com>

[WPE][GTK] Expose availability of certain editing commands in WebKitEditorState
Expand Down
5 changes: 0 additions & 5 deletions Tools/Scripts/webkitdirs.pm
Expand Up @@ -2460,11 +2460,6 @@ sub setupIOSWebKitEnvironment($)

sub iosSimulatorApplicationsPath()
{
determineXcodeVersion();
if (eval "v$xcodeVersion" lt v9.0) {
return File::Spec->catdir(XcodeSDKPath(), "Applications");
}

my $iphoneOSPlatformPath = sdkPlatformDirectory("iphoneos");
return File::Spec->catdir($iphoneOSPlatformPath, "Developer", "Library", "CoreSimulator", "Profiles", "Runtimes", "iOS.simruntime", "Contents", "Resources", "RuntimeRoot", "Applications");
}
Expand Down

0 comments on commit e200c1a

Please sign in to comment.