Web Inspector: Spacebar to start recording should not cause system beep

https://bugs.webkit.org/show_bug.cgi?id=150573

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-10-26
Reviewed by Timothy Hatcher.

* UserInterface/Views/TimelineSidebarPanel.js:
(WebInspector.TimelineSidebarPanel.prototype._toggleRecordingOnSpacebar):
(WebInspector.TimelineSidebarPanel.prototype._toggleNewRecordingOnSpacebar):
The keyboard shortcuts do not implicitly prevent default because they may bail.
So in cases where they do handle the key, prevent default to prevent system beeps.

Canonical link: https://commits.webkit.org/168732@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@191613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebInspectorUI/ChangeLog

@@ -1,3 +1,16 @@
+2015-10-26  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Spacebar to start recording should not cause system beep
+        https://bugs.webkit.org/show_bug.cgi?id=150573
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Views/TimelineSidebarPanel.js:
+        (WebInspector.TimelineSidebarPanel.prototype._toggleRecordingOnSpacebar):
+        (WebInspector.TimelineSidebarPanel.prototype._toggleNewRecordingOnSpacebar):
+        The keyboard shortcuts do not implicitly prevent default because they may bail.
+        So in cases where they do handle the key, prevent default to prevent system beeps.
+
 2015-10-26  Matt Baker  <mattbaker@apple.com>
 
         Web Inspector: Cleanup sidebar panels, reduce `delete` and use Maps instead of objects

Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js

@@ -532,6 +532,8 @@ WebInspector.TimelineSidebarPanel = class TimelineSidebarPanel extends WebInspec
             return;
 
         this._toggleRecording();
+
+        event.preventDefault();
     }
 
     _toggleNewRecordingOnSpacebar(event)
@@ -540,6 +542,8 @@ WebInspector.TimelineSidebarPanel = class TimelineSidebarPanel extends WebInspec
             return;
 
         this._toggleRecording(true);
+
+        event.preventDefault();
     }
 
     _toggleRecording(shouldCreateRecording)