Remove [ConstructorParameters] from IDL files that have [Constructor]

https://bugs.webkit.org/show_bug.cgi?id=79643 Reviewed by Adam Barth. This patch removes [ConstructorParameters] from IDL files that have [Constructor], since CodeGeneratorJS.pm can automatically detect the number of constructor arguments by the [Constructor(...)] signature. Test: fast/js/constructor-length.html * Modules/mediastream/PeerConnection.idl: * bindings/scripts/CodeGeneratorJS.pm: (GenerateConstructorDefinition): * css/WebKitCSSMatrix.idl: * page/EventSource.idl: * workers/SharedWorker.idl: * workers/Worker.idl: Canonical link: https://commits.webkit.org/96794@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109029 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WebKit · Feb 27, 2012 · e40c5d14649e74c2a001548b27d05e3ea58707e2 · e40c5d1
1 parent 75ca704
commit e40c5d14649e74c2a001548b27d05e3ea58707e2
diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
@@ -1,3 +1,24 @@
+2012-02-27  Kentaro Hara  <haraken@chromium.org>
+
+        Remove [ConstructorParameters] from IDL files that have [Constructor]
+        https://bugs.webkit.org/show_bug.cgi?id=79643
+
+        Reviewed by Adam Barth.
+
+        This patch removes [ConstructorParameters] from IDL files that have [Constructor],
+        since CodeGeneratorJS.pm can automatically detect the number of constructor
+        arguments by the [Constructor(...)] signature.
+
+        Test: fast/js/constructor-length.html
+
+        * Modules/mediastream/PeerConnection.idl:
+        * bindings/scripts/CodeGeneratorJS.pm:
+        (GenerateConstructorDefinition):
+        * css/WebKitCSSMatrix.idl:
+        * page/EventSource.idl:
+        * workers/SharedWorker.idl:
+        * workers/Worker.idl:
+
 2012-02-27  Julien Chaffraix  <jchaffraix@webkit.org>
 
         Avoid doing 2 hash lookups if we override RenderBox's logical width / height

diff --git a/Source/WebCore/Modules/mediastream/PeerConnection.idl b/Source/WebCore/Modules/mediastream/PeerConnection.idl
@@ -27,7 +27,6 @@ module p2p {
     interface [
         Conditional=MEDIA_STREAM,
         ActiveDOMObject,
-        ConstructorParameters=2,
         Constructor(in DOMString serverConfiguration, in [Callback] SignalingCallback signalingCallback),
         CallWith=ScriptExecutionContext,
         JSCustomConstructor,

diff --git a/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm b/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
@@ -3368,7 +3368,7 @@ sub GenerateConstructorDefinition
     if (!defined $numberOfConstructorParameters) {
         if (IsConstructorTemplate($dataNode, "Event")) {
             $numberOfConstructorParameters = 2;
-        } elsif ($dataNode->extendedAttributes->{"Constructor"} and !$dataNode->extendedAttributes->{"CustomConstructor"} and !$dataNode->extendedAttributes->{"JSCustomConstructor"}) {
+        } elsif ($dataNode->extendedAttributes->{"Constructor"}) {
             $numberOfConstructorParameters = @{$dataNode->constructor->parameters};
         }
     }

diff --git a/Source/WebCore/css/WebKitCSSMatrix.idl b/Source/WebCore/css/WebKitCSSMatrix.idl
@@ -27,7 +27,6 @@ module css {
 
     // Introduced in DOM Level ?:
     interface [
-        ConstructorParameters=1,
         Constructor(in [Optional=DefaultIsNullString] DOMString cssValue),
         ConstructorRaisesException,
     ] WebKitCSSMatrix {

diff --git a/Source/WebCore/page/EventSource.idl b/Source/WebCore/page/EventSource.idl
@@ -33,7 +33,6 @@ module window {
 
     interface [
         ActiveDOMObject,
-        ConstructorParameters=1,
         Constructor(in DOMString scriptUrl),
         CallWith=ScriptExecutionContext,
         ConstructorRaisesException,

diff --git a/Source/WebCore/workers/SharedWorker.idl b/Source/WebCore/workers/SharedWorker.idl
@@ -35,7 +35,6 @@ module threads {
         Conditional=SHARED_WORKERS,
         ActiveDOMObject,
         JSCustomConstructor,
-        ConstructorParameters=2,
         Constructor(in DOMString scriptURL, in [Optional=DefaultIsNullString] DOMString name),
         CallWith=ScriptExecutionContext,
         ConstructorRaisesException,

diff --git a/Source/WebCore/workers/Worker.idl b/Source/WebCore/workers/Worker.idl
@@ -31,7 +31,6 @@ module threads {
         Conditional=WORKERS,
         ActiveDOMObject,
         JSCustomConstructor,
-        ConstructorParameters=1,
         Constructor(in DOMString scriptUrl),
         CallWith=ScriptExecutionContext,
         ConstructorRaisesException,