Skip to content
Permalink
Browse files
REGRESSION (250413@main): [ iOS ] system-preview/badge.html is a cons…
…istent image failure

https://bugs.webkit.org/show_bug.cgi?id=240352
rdar://93191053

Patch by Antoine Quint <graouts@apple.com> on 2022-05-23
Reviewed by Simon Fraser.

In the case of an ARKit image, we should only be returning when we don't
have a native image to record, otherwise the system image itself needs
to be recorded as well.

* LayoutTests/platform/ios-wk2/TestExpectations:
* Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp:
(WebCore::DisplayList::Recorder::drawSystemImage):

Canonical link: https://commits.webkit.org/250907@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294729 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
graouts authored and webkit-commit-queue committed May 24, 2022
1 parent 0f3a1e2 commit e5460194a881d767a4df8aa27de79ac0b8ac9ff2
Showing 2 changed files with 4 additions and 5 deletions.
@@ -2236,8 +2236,6 @@ imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-e

fast/text/install-font-style-recalc.html [ Pass ]

webkit.org/b/240352 system-preview/badge.html [ ImageOnlyFailure ]

# webkit.org/b/240579 Disabling the following http/tests/workers/service/shownotification layout-tests on iOS
http/tests/workers/service/shownotification-allowed-document.html [ Skip ]
http/tests/workers/service/shownotification-allowed.html [ Skip ]
@@ -205,10 +205,11 @@ void Recorder::drawSystemImage(SystemImage& systemImage, const FloatRect& destin
#if USE(SYSTEM_PREVIEW)
if (is<ARKitBadgeSystemImage>(systemImage)) {
if (auto image = downcast<ARKitBadgeSystemImage>(systemImage).image()) {
if (auto nativeImage = image->nativeImage())
recordResourceUse(*nativeImage);
auto nativeImage = image->nativeImage();
if (!nativeImage)
return;
recordResourceUse(*nativeImage);
}
return;
}
#endif
recordDrawSystemImage(systemImage, destinationRect);

0 comments on commit e546019

Please sign in to comment.