Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
[RenderTreeBuilder] Introduce RenderTreebuilder::takeChild
https://bugs.webkit.org/show_bug.cgi?id=182707 <rdar://problem/37473433> Reviewed by Antti Koivisto. All takeChild calls should go through RenderTreeBuilder::takeChild from now on. This patch also moves the Ruby related takeChild calls to RenderTreeBuilder. No change in functionality. * rendering/RenderButton.cpp: (WebCore::RenderButton::takeChild): * rendering/RenderElement.cpp: (WebCore::RenderElement::removeAndDestroyChild): * rendering/RenderFullScreen.cpp: (WebCore::RenderFullScreen::wrapExistingRenderer): (WebCore::RenderFullScreen::unwrapRenderer): * rendering/RenderMenuList.cpp: (RenderMenuList::takeChild): * rendering/RenderRuby.cpp: (WebCore::RenderRubyAsInline::takeChild): Deleted. (WebCore::RenderRubyAsBlock::takeChild): Deleted. * rendering/RenderRuby.h: * rendering/RenderRubyRun.cpp: (WebCore::RenderRubyRun::takeChild): Deleted. * rendering/RenderRubyRun.h: * rendering/updating/RenderTreeBuilder.cpp: (WebCore::RenderTreeBuilder::takeChild): (WebCore::RenderTreeBuilder::takeChildFromRenderRubyAsInline): Deleted. (WebCore::RenderTreeBuilder::takeChildFromRenderRubyAsBlock): Deleted. (WebCore::RenderTreeBuilder::takeChildFromRenderRubyRun): Deleted. * rendering/updating/RenderTreeBuilder.h: * rendering/updating/RenderTreeBuilderFirstLetter.cpp: (WebCore::RenderTreeBuilder::FirstLetter::updateStyle): * rendering/updating/RenderTreeBuilderList.cpp: (WebCore::RenderTreeBuilder::List::updateItemMarker): * rendering/updating/RenderTreeBuilderMultiColumn.cpp: (WebCore::RenderTreeBuilder::MultiColumn::createFragmentedFlow): (WebCore::RenderTreeBuilder::MultiColumn::destroyFragmentedFlow): (WebCore::RenderTreeBuilder::MultiColumn::processPossibleSpannerDescendant): * rendering/updating/RenderTreeBuilderRuby.cpp: (WebCore::RenderTreeBuilder::Ruby::takeChild): * rendering/updating/RenderTreeBuilderTable.cpp: (WebCore::RenderTreeBuilder::Table::collapseAndDestroyAnonymousSiblingRows): Canonical link: https://commits.webkit.org/198506@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@228400 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- Loading branch information
Showing
with
79 additions
and 53 deletions.
- +48 −0 Source/WebCore/ChangeLog
- +1 −1 Source/WebCore/rendering/RenderButton.cpp
- +1 −1 Source/WebCore/rendering/RenderElement.cpp
- +2 −2 Source/WebCore/rendering/RenderFullScreen.cpp
- +1 −1 Source/WebCore/rendering/RenderMenuList.cpp
- +0 −10 Source/WebCore/rendering/RenderRuby.cpp
- +0 −4 Source/WebCore/rendering/RenderRuby.h
- +0 −5 Source/WebCore/rendering/RenderRubyRun.cpp
- +0 −1 Source/WebCore/rendering/RenderRubyRun.h
- +14 −15 Source/WebCore/rendering/updating/RenderTreeBuilder.cpp
- +2 −3 Source/WebCore/rendering/updating/RenderTreeBuilder.h
- +1 −1 Source/WebCore/rendering/updating/RenderTreeBuilderFirstLetter.cpp
- +1 −1 Source/WebCore/rendering/updating/RenderTreeBuilderList.cpp
- +3 −3 Source/WebCore/rendering/updating/RenderTreeBuilderMultiColumn.cpp
- +4 −4 Source/WebCore/rendering/updating/RenderTreeBuilderRuby.cpp
- +1 −1 Source/WebCore/rendering/updating/RenderTreeBuilderTable.cpp
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters