Skip to content
Permalink
Browse files
2010-07-22 Andrey Kosyakov <caseq@chromium.org>
        Reviewed by Yury Semikhatsky.

        Web Inspector: Stop granting universal access to inspector front-end page.
        https://bugs.webkit.org/show_bug.cgi?id=42817

        * inspector/InspectorFrontendClientLocal.cpp:
        (WebCore::InspectorFrontendClientLocal::windowObjectCleared):
2010-07-22  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Stop granting universal access to inspector front-end page.
        https://bugs.webkit.org/show_bug.cgi?id=42817

        * src/WebDevToolsFrontendImpl.cpp:
        (WebKit::WebDevToolsFrontendImpl::frontendLoaded):

Canonical link: https://commits.webkit.org/54733@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63896 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
webkit-commit-queue committed Jul 22, 2010
1 parent 5eea655 commit e6e749425d816a2806c68afb534d768a660edbc9
Showing with 20 additions and 6 deletions.
  1. +10 −0 WebCore/ChangeLog
  2. +0 −2 WebCore/inspector/InspectorFrontendClientLocal.cpp
  3. +10 −0 WebKit/chromium/ChangeLog
  4. +0 −4 WebKit/chromium/src/WebDevToolsFrontendImpl.cpp
@@ -1,3 +1,13 @@
2010-07-22 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Stop granting universal access to inspector front-end page.
https://bugs.webkit.org/show_bug.cgi?id=42817

* inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorFrontendClientLocal::windowObjectCleared):

2010-07-22 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Fix inspector console tests crashes.
@@ -70,8 +70,6 @@ InspectorFrontendClientLocal::~InspectorFrontendClientLocal()

void InspectorFrontendClientLocal::windowObjectCleared()
{
// Grant the inspector the ability to script the inspected page.
m_frontendPage->mainFrame()->document()->securityOrigin()->grantUniversalAccess();
// FIXME: don't keep reference to the script state
m_frontendScriptState = scriptStateFromPage(debuggerWorld(), m_frontendPage);
ScriptGlobalObject::set(m_frontendScriptState, "InspectorBackend", m_inspectorController->inspectorBackend());
@@ -1,3 +1,13 @@
2010-07-22 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Stop granting universal access to inspector front-end page.
https://bugs.webkit.org/show_bug.cgi?id=42817

* src/WebDevToolsFrontendImpl.cpp:
(WebKit::WebDevToolsFrontendImpl::frontendLoaded):

2010-07-22 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.
@@ -150,10 +150,6 @@ void WebDevToolsFrontendImpl::frontendLoaded()
{
m_loaded = true;

// Grant the devtools page the ability to have source view iframes.
SecurityOrigin* origin = m_webViewImpl->page()->mainFrame()->domWindow()->securityOrigin();
origin->grantUniversalAccess();

for (Vector<Vector<String> >::iterator it = m_pendingIncomingMessages.begin();
it != m_pendingIncomingMessages.end();
++it) {

0 comments on commit e6e7494

Please sign in to comment.