Skip to content
Permalink
Browse files
CodeBlockSet::traceMarked doesn't need to visit the ownerExecutable
https://bugs.webkit.org/show_bug.cgi?id=127301

Reviewed by Oliver Hunt.

We used to just call CodeBlock::visitAggregate, but now we call visitChildren
on the ownerExecutable, which is unnecessary.

* heap/CodeBlockSet.cpp:
(JSC::CodeBlockSet::traceMarked):


Canonical link: https://commits.webkit.org/145299@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162377 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
Mark Hahnenberg committed Jan 20, 2014
1 parent 05a8e29 commit e720af00bb3693ff24b621b967535d5fa34ddf43
Showing 2 changed files with 14 additions and 1 deletion.
@@ -1,3 +1,16 @@
2014-01-20 Mark Hahnenberg <mhahnenberg@apple.com>

CodeBlockSet::traceMarked doesn't need to visit the ownerExecutable
https://bugs.webkit.org/show_bug.cgi?id=127301

Reviewed by Oliver Hunt.

We used to just call CodeBlock::visitAggregate, but now we call visitChildren
on the ownerExecutable, which is unnecessary.

* heap/CodeBlockSet.cpp:
(JSC::CodeBlockSet::traceMarked):

2014-01-20 Anders Carlsson <andersca@apple.com>

Fix build.
@@ -102,7 +102,7 @@ void CodeBlockSet::traceMarked(SlotVisitor& visitor)
CodeBlock* codeBlock = *iter;
if (!codeBlock->m_mayBeExecuting)
continue;
codeBlock->ownerExecutable()->methodTable()->visitChildren(codeBlock->ownerExecutable(), visitor);
codeBlock->visitAggregate(visitor);
}
}

0 comments on commit e720af0

Please sign in to comment.