Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
[Mac] Content briefly zooms in when exiting PIP
https://bugs.webkit.org/show_bug.cgi?id=255892
rdar://107835087

Reviewed by Eric Carlson.

When we changed VideoFullscreenInterfaceMac to use WebAVPlayerLayer, it meant that explicitly
resizing the layer on PiP exit was no longer necessary; that's handled by WebAVPlayerLayer itself.

* Source/WebCore/platform/mac/VideoFullscreenInterfaceMac.mm:
(-[WebVideoFullscreenInterfaceMacObjC pipDidClose:]):

Canonical link: https://commits.webkit.org/263350@main
  • Loading branch information
jernoble authored and jyavenard committed Apr 25, 2023
1 parent afb1339 commit e7b9c37
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions Source/WebCore/platform/mac/VideoFullscreenInterfaceMac.mm
Expand Up @@ -333,9 +333,6 @@ - (void)pipDidClose:(PIPViewController *)pip
[NSAnimationContext runAnimationGroup:^(NSAnimationContext *context) {
context.allowsImplicitAnimation = NO;
[_videoViewContainer setFrame:_returningRect];
_videoFullscreenInterfaceMac->videoFullscreenModel()->setVideoLayerFrame([_videoViewContainer bounds]);
_videoFullscreenInterfaceMac->videoFullscreenModel()->setVideoLayerGravity(MediaPlayerEnums::VideoGravity::ResizeAspect);

[[_returningWindow contentView] addSubview:_videoViewContainer.get() positioned:NSWindowAbove relativeTo:nil];
} completionHandler:nil];
}
Expand Down

0 comments on commit e7b9c37

Please sign in to comment.