Skip to content
Permalink
Browse files
2010-07-20 Tony Chang <tony@chromium.org>
        Reviewed by Kent Tamura.

        [chromium] by default, dumpAsText should disable pixel results
        https://bugs.webkit.org/show_bug.cgi?id=42715

        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::dumpAsText): disable pixel results, but allow JS to override

Canonical link: https://commits.webkit.org/54633@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63796 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
idealisms committed Jul 21, 2010
1 parent 846053d commit e7de0fb5147c3c59985cf07907463d4f0ca42541
Showing with 11 additions and 0 deletions.
  1. +10 −0 WebKitTools/ChangeLog
  2. +1 −0 WebKitTools/DumpRenderTree/chromium/LayoutTestController.cpp
@@ -1,3 +1,13 @@
2010-07-20 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] by default, dumpAsText should disable pixel results
https://bugs.webkit.org/show_bug.cgi?id=42715

* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::dumpAsText): disable pixel results, but allow JS to override

2010-07-20 Adam Roben <aroben@apple.com>

Windows build fix
@@ -233,6 +233,7 @@ void LayoutTestController::WorkQueue::addWork(WorkItem* work)
void LayoutTestController::dumpAsText(const CppArgumentList& arguments, CppVariant* result)
{
m_dumpAsText = true;
m_generatePixelResults = false;

// Optional paramater, describing whether it's allowed to dump pixel results in dumpAsText mode.
if (arguments.size() > 0 && arguments[0].isBool())

0 comments on commit e7de0fb

Please sign in to comment.