Skip to content
Permalink
Browse files
Homograph with LATIN SMALL LETTER R WITH FISHHOOK
https://bugs.webkit.org/show_bug.cgi?id=192944

Reviewed by Tim Horton.

Source/WTF:

* wtf/cocoa/NSURLExtras.mm:
(WTF::isLookalikeCharacter):

Tools:

* TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
(TestWebKitAPI::TEST):



Canonical link: https://commits.webkit.org/207616@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239586 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
achristensen07 committed Jan 3, 2019
1 parent 35cd02d commit e84f96e9d6f3529755c346f5d03214c09f7034cc
Showing with 23 additions and 2 deletions.
  1. +10 −0 Source/WTF/ChangeLog
  2. +2 −2 Source/WTF/wtf/cocoa/NSURLExtras.mm
  3. +10 −0 Tools/ChangeLog
  4. +1 −0 Tools/TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm
@@ -1,3 +1,13 @@
2019-01-02 Alex Christensen <achristensen@webkit.org>

Homograph with LATIN SMALL LETTER R WITH FISHHOOK
https://bugs.webkit.org/show_bug.cgi?id=192944

Reviewed by Tim Horton.

* wtf/cocoa/NSURLExtras.mm:
(WTF::isLookalikeCharacter):

2019-01-02 Commit Queue <commit-queue@webkit.org>

Unreviewed, rolling out r239524.
@@ -92,8 +92,6 @@ static bool isArmenianScriptCharacter(UChar32 codePoint)
}
}



static BOOL isLookalikeCharacter(Optional<UChar32> previousCodePoint, UChar32 charCode)
{
// This function treats the following as unsafe, lookalike characters:
@@ -115,9 +113,11 @@ static BOOL isLookalikeCharacter(Optional<UChar32> previousCodePoint, UChar32 ch
case 0x00BD: /* VULGAR FRACTION ONE HALF */
case 0x00BE: /* VULGAR FRACTION THREE QUARTERS */
case 0x00ED: /* LATIN SMALL LETTER I WITH ACUTE */
/* 0x0131 LATIN SMALL LETTER DOTLESS I is intentionally not considered a lookalike character because it is visually distinguishable from i and it has legitimate use in the Turkish language. */
case 0x01C3: /* LATIN LETTER RETROFLEX CLICK */
case 0x0251: /* LATIN SMALL LETTER ALPHA */
case 0x0261: /* LATIN SMALL LETTER SCRIPT G */
case 0x027E: /* LATIN SMALL LETTER R WITH FISHHOOK */
case 0x02D0: /* MODIFIER LETTER TRIANGULAR COLON */
case 0x0335: /* COMBINING SHORT STROKE OVERLAY */
case 0x0337: /* COMBINING SHORT SOLIDUS OVERLAY */
@@ -1,3 +1,13 @@
2019-01-02 Alex Christensen <achristensen@webkit.org>

Homograph with LATIN SMALL LETTER R WITH FISHHOOK
https://bugs.webkit.org/show_bug.cgi?id=192944

Reviewed by Tim Horton.

* TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
(TestWebKitAPI::TEST):

2019-01-02 Wenson Hsieh <wenson_hsieh@apple.com>

Add support for using the current text selection as the find string on iOS
@@ -101,6 +101,7 @@
"xn--qdb1b", // U+05D5 U+05C2
"xn--sdb7a", // U+05D5 U+05C4
"xn--2-zic", // U+0032 U+05E1
"xn--uoa", // U+027E
};
for (const String& host : punycodedSpoofHosts) {
auto url = makeString("http://", host, "/").utf8();

0 comments on commit e84f96e

Please sign in to comment.