Skip to content
Permalink
Browse files
Unreviewed, fix build warnings after content extensions enablement
https://bugs.webkit.org/show_bug.cgi?id=193622
<rdar://problem/47982850>

Source/WebCore:

* contentextensions/DFABytecode.h:
(WebCore::ContentExtensions::instructionSizeWithArguments):
* contentextensions/DFABytecodeCompiler.h:
* contentextensions/URLFilterParser.cpp:
(WebCore::ContentExtensions::URLFilterParser::statusString):

Source/WebKit:

* UIProcess/API/C/WKUserContentExtensionStoreRef.cpp:
(toResult):

Canonical link: https://commits.webkit.org/208971@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@241316 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
Michael Catanzaro committed Feb 12, 2019
1 parent 3521e06 commit e85d8abcbf7080b0494141633ddbc73715de0eac
Showing 6 changed files with 27 additions and 1 deletion.
@@ -1,3 +1,15 @@
2019-02-12 Michael Catanzaro <mcatanzaro@igalia.com>

Unreviewed, fix build warnings after content extensions enablement
https://bugs.webkit.org/show_bug.cgi?id=193622
<rdar://problem/47982850>

* contentextensions/DFABytecode.h:
(WebCore::ContentExtensions::instructionSizeWithArguments):
* contentextensions/DFABytecodeCompiler.h:
* contentextensions/URLFilterParser.cpp:
(WebCore::ContentExtensions::URLFilterParser::statusString):

2019-02-12 Justin Fan <justin_fan@apple.com>

[Web GPU] DepthStencilAttachment implementation
@@ -126,6 +126,7 @@ static inline size_t instructionSizeWithArguments(DFABytecodeInstruction instruc
case DFABytecodeInstruction::Terminate:
return sizeof(DFABytecodeInstruction);
}
RELEASE_ASSERT_NOT_REACHED();
}

} // namespace ContentExtensions
@@ -64,7 +64,7 @@ class WEBCORE_EXPORT DFABytecodeCompiler {
struct JumpTable {
~JumpTable()
{
ASSERT(min + destinations.size() == max + 1);
ASSERT(min + destinations.size() == static_cast<size_t>(max + 1));
ASSERT(min == max || destinations.size() > 1);
}

@@ -403,6 +403,8 @@ String URLFilterParser::statusString(ParseStatus status)
case InvalidQuantifier:
return "Arbitrary atom repetitions are not supported.";
}

RELEASE_ASSERT_NOT_REACHED();
}

} // namespace ContentExtensions
@@ -1,3 +1,12 @@
2019-02-12 Michael Catanzaro <mcatanzaro@igalia.com>

Unreviewed, fix build warnings after content extensions enablement
https://bugs.webkit.org/show_bug.cgi?id=193622
<rdar://problem/47982850>

* UIProcess/API/C/WKUserContentExtensionStoreRef.cpp:
(toResult):

2019-02-12 Tim Horton <timothy_horton@apple.com>

Switching focus from a UITextField to an editable WKWebView causes the keyboard to dance
@@ -68,6 +68,8 @@ static inline WKUserContentExtensionStoreResult toResult(const std::error_code&
case API::ContentRuleListStore::Error::RemoveFailed:
return kWKUserContentExtensionStoreRemoveFailed;
}

RELEASE_ASSERT_NOT_REACHED();
}
#endif

0 comments on commit e85d8ab

Please sign in to comment.