Skip to content
Permalink
Browse files
Don't force creation of process pool when enabling resource load stat…
…istics

https://bugs.webkit.org/show_bug.cgi?id=180374
<rdar://problem/35545639>

Reviewed by Alex Christensen.

Pass appropriate arguments to the 'processPool' accessor so that we only get the
set of existing process pools. We don't want to pay the cost of launching new
process pools just to set this flag. The flag will be properly set when the pools
are created as soon as a WebView is instantiated.

* UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::setResourceLoadStatisticsEnabled):


Canonical link: https://commits.webkit.org/196349@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225508 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
brentfulgham committed Dec 5, 2017
1 parent ca1e8ed commit e8e6afd200e9e7f4d2b36bf8ffa736422295867a
Showing with 19 additions and 1 deletion.
  1. +16 −0 Source/WebKit/ChangeLog
  2. +3 −1 Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp
@@ -1,3 +1,19 @@
2017-12-04 Brent Fulgham <bfulgham@apple.com>

Don't force creation of process pool when enabling resource load statistics
https://bugs.webkit.org/show_bug.cgi?id=180374
<rdar://problem/35545639>

Reviewed by Alex Christensen.

Pass appropriate arguments to the 'processPool' accessor so that we only get the
set of existing process pools. We don't want to pay the cost of launching new
process pools just to set this flag. The flag will be properly set when the pools
are created as soon as a WebView is instantiated.

* UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::setResourceLoadStatisticsEnabled):

2017-12-04 David Quesada <david_quesada@apple.com>

Add a class for parsing application manifests
@@ -1326,7 +1326,9 @@ void WebsiteDataStore::setResourceLoadStatisticsEnabled(bool enabled)
}

m_resourceLoadStatistics = nullptr;
for (auto& processPool : processPools())

auto existingProcessPools = processPools(std::numeric_limits<size_t>::max(), false);
for (auto& processPool : existingProcessPools)
processPool->setResourceLoadStatisticsEnabled(false);
}

0 comments on commit e8e6afd

Please sign in to comment.