Skip to content
Permalink
Browse files
[GTK] Inspector protocol tests timing out on the bots
https://bugs.webkit.org/show_bug.cgi?id=122571

Reviewed by Devin Rousso.

Mark more inspector tests as passing on GTK.

* inspector/dom/focus.html: Remove 'focus' event listener before closing dummy inspector
window. Otherwise it triggers a WebPage::setActivityState which in turn triggers focus
event on the page and on the focused element which results in two extra 'focus' lines printed.
To be clear this only avoids the extra text output that could be added to the output. Timeout
and crash problems must have been fixed before (likely by the recent changes in local inspector
client).
* platform/gtk/TestExpectations:


Canonical link: https://commits.webkit.org/217186@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@252027 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
yury-s committed Nov 5, 2019
1 parent 542eccc commit e91aaa7ac68414d7940f8fa2478174b4a07340d2
Showing with 33 additions and 12 deletions.
  1. +17 −0 LayoutTests/ChangeLog
  2. +16 −4 LayoutTests/inspector/dom/focus.html
  3. +0 −8 LayoutTests/platform/gtk/TestExpectations
@@ -1,3 +1,20 @@
2019-11-04 Yury Semikhatsky <yurys@chromium.org>

[GTK] Inspector protocol tests timing out on the bots
https://bugs.webkit.org/show_bug.cgi?id=122571

Reviewed by Devin Rousso.

Mark more inspector tests as passing on GTK.

* inspector/dom/focus.html: Remove 'focus' event listener before closing dummy inspector
window. Otherwise it triggers a WebPage::setActivityState which in turn triggers focus
event on the page and on the focused element which results in two extra 'focus' lines printed.
To be clear this only avoids the extra text output that could be added to the output. Timeout
and crash problems must have been fixed before (likely by the recent changes in local inspector
client).
* platform/gtk/TestExpectations:

2019-11-04 Truitt Savell <tsavell@apple.com>

Unreviewed, rolling out r251993.
@@ -2,12 +2,21 @@
<head>
<script src="../../http/tests/inspector/resources/protocol-test.js"></script>
<script>

function focusListener()
{
log("focused");
}

window.addEventListener("load", function() {
document.querySelector("#second").addEventListener("focus", function() {
log("focused");
});
document.querySelector("#second").addEventListener("focus", focusListener);
});

function removeFocusListener()
{
document.querySelector("#second").removeEventListener("focus", focusListener);
}

function test()
{
InspectorProtocol.sendCommand("DOM.getDocument", {}, onGotDocument);
@@ -35,7 +44,10 @@
function onFocus(msg) {
if (msg.error)
ProtocolTest.log(msg.error);
ProtocolTest.completeTest();
ProtocolTest.evaluateInPage("removeFocusListener()")
.then(() => {
ProtocolTest.completeTest();
});
}
}
</script>
@@ -2331,14 +2331,6 @@ webkit.org/b/116957 media/track/track-automatic-subtitles.html [ Timeout ]
webkit.org/b/120682 inspector/page/archive.html [ Timeout ]

webkit.org/b/147518 inspector/debugger/nested-inspectors.html [ Timeout ]
webkit.org/b/122571 http/tests/inspector/dom/cross-domain-inspected-node-access.html [ Timeout Pass ]
webkit.org/b/122571 inspector/dom/focus.html [ Failure Timeout Pass ]
webkit.org/b/122571 inspector/runtime/getProperties.html [ Timeout Pass Crash ]
webkit.org/b/122571 inspector/runtime/saveResult.html [ Timeout Pass Crash ]
webkit.org/b/122571 inspector/page/frameStartedLoading.html [ Timeout Pass ]
webkit.org/b/122571 inspector/page/frameScheduledNavigation.html [ Timeout Pass Crash ]
webkit.org/b/122571 inspector/page/setEmulatedMedia.html [ Timeout Pass ]
webkit.org/b/122571 inspector/css/getSupportedCSSProperties.html [ Timeout Pass ]

Bug(GTK) plugins/reloadplugins-and-pages.html [ Timeout ]

0 comments on commit e91aaa7

Please sign in to comment.