Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
grammar-markers.html and grammar-markers-hidpi.html pass even if elem…
…ent does not have grammar marker https://bugs.webkit.org/show_bug.cgi?id=119797 Reviewed by Ryosuke Niwa. After tenth attempts of verifying the grammar marker, the tests call'notifyDone' even if grammar marker was not be found. Both grammar-marker.html and grammar-marker-hidpi.html call the text checker asynchronously. Therefore, we need to wait until either the grammar marker is found or number of attempts is reached. Dump more information whether the grammar marker was found to be sure that the tests do not pass when the element does not have the marker. * editing/spelling/grammar-markers-expected.txt: * editing/spelling/grammar-markers-hidpi-expected.txt: Update the expectations. * editing/spelling/grammar-markers-hidpi.html: * editing/spelling/grammar-markers.html: Dump more information. Additionally, pass 'document' to hasGrammarMarker instead of 'target' as the method does not work for target/source elements. * platform/mac/editing/spelling/grammar-markers-expected.png: * platform/mac/editing/spelling/grammar-markers-hidpi-expected.png: Added. Update the expectations for Mac. Canonical link: https://commits.webkit.org/138321@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@154675 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- Loading branch information
Showing
with
110 additions
and 26 deletions.
- +31 −0 LayoutTests/ChangeLog
- +8 −1 LayoutTests/editing/spelling/grammar-markers-expected.txt
- +8 −1 LayoutTests/editing/spelling/grammar-markers-hidpi-expected.txt
- +32 −13 LayoutTests/editing/spelling/grammar-markers-hidpi.html
- +31 −11 LayoutTests/editing/spelling/grammar-markers.html
- BIN LayoutTests/platform/mac/editing/spelling/grammar-markers-expected.png
- BIN LayoutTests/platform/mac/editing/spelling/grammar-markers-hidpi-expected.png
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -1,4 +1,11 @@ | ||
This tests whether WebKit can render grammar markers when pasting text if it has a grammar-checker. To test manually, copy the text in the first div element and paste it to the second div element. This test succeeds when WebKit renders a grammar marker under a word "has". | ||
|
||
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". | ||
|
||
|
||
PASS hasMarker is true | ||
PASS successfullyParsed is true | ||
|
||
TEST COMPLETE | ||
You has the right. | ||
You has the right. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -1,4 +1,11 @@ | ||
This tests whether WebKit can render grammar markers when pasting text if it has a grammar-checker. To test manually, copy the text in the first div element and paste it to the second div element. This test succeeds when WebKit renders a grammar marker under a word "has". | ||
|
||
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". | ||
|
||
|
||
PASS hasMarker is true | ||
PASS successfullyParsed is true | ||
|
||
TEST COMPLETE | ||
You has the right. | ||
You has the right. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.