Skip to content
Permalink
Browse files
[iOS] UIDelegate::UIClient::fullscreenMayReturnToInline() is not call…
…ed when a video exits fullscreen

https://bugs.webkit.org/show_bug.cgi?id=226785

Reviewed by Eric Carlson.

On iOS, `UIDelegate::UIClient::fullscreenMayReturnToInline()` is called when
a video exits picture-in-picture, but not when a video exits fullscreen.
This patch fixes that.

We cannot add a regression test for this patch before fixing webkit.org/b/212654.

* UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:
(WebKit::VideoFullscreenManagerProxy::exitFullscreen):


Canonical link: https://commits.webkit.org/238645@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@278663 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
pliu6 committed Jun 9, 2021
1 parent d46fa32 commit eb1c37cf31d76ff80cffc017f544af9f40caef14
Showing 2 changed files with 19 additions and 0 deletions.
@@ -1,3 +1,19 @@
2021-06-09 Peng Liu <peng.liu6@apple.com>

[iOS] UIDelegate::UIClient::fullscreenMayReturnToInline() is not called when a video exits fullscreen
https://bugs.webkit.org/show_bug.cgi?id=226785

Reviewed by Eric Carlson.

On iOS, `UIDelegate::UIClient::fullscreenMayReturnToInline()` is called when
a video exits picture-in-picture, but not when a video exits fullscreen.
This patch fixes that.

We cannot add a regression test for this patch before fixing webkit.org/b/212654.

* UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:
(WebKit::VideoFullscreenManagerProxy::exitFullscreen):

2021-06-09 Diego Pino Garcia <dpino@igalia.com>

[GTK] Do not depend on resources provided by the GNOME icon theme
@@ -625,6 +625,9 @@ - (BOOL)prefersStatusBarHidden
#if !PLATFORM(IOS_FAMILY)
IntRect finalWindowRect;
m_page->rootViewToWindow(enclosingIntRect(finalRect), finalWindowRect);
#else
if (hasMode(WebCore::HTMLMediaElementEnums::VideoFullscreenModeStandard))
m_page->fullscreenMayReturnToInline();
#endif

if (m_mockVideoPresentationModeEnabled) {

0 comments on commit eb1c37c

Please sign in to comment.