Skip to content
Permalink
Browse files
Unreviewed, rolling out r199916.
https://bugs.webkit.org/show_bug.cgi?id=156989

Might break buildbot when master is restarted (Requested by
Srinivasan Vijayaraghava, Guest100, on #webkit).

Reverted changeset:

"Add JSC test results in json format to a buildbot log"
https://bugs.webkit.org/show_bug.cgi?id=156920
http://trac.webkit.org/changeset/199916

Patch by Commit Queue <commit-queue@webkit.org> on 2016-04-25

Canonical link: https://commits.webkit.org/175096@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@200040 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
webkit-commit-queue authored and dydz committed Apr 25, 2016
1 parent e669210 commit ec0b893f7efecd27c8d115426d666bda250daa94
Showing with 19 additions and 6 deletions.
  1. +3 −5 Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg
  2. +14 −0 Tools/ChangeLog
  3. +2 −1 Tools/Scripts/run-javascriptcore-tests
@@ -44,7 +44,7 @@ authz = Authz(

c['status'] = []
c['status'].append(html.WebStatus(http_port=8710,
revlink="https://trac.webkit.org/changeset/%s",
revlink="https://trac.webkit.org/changeset/%s",
changecommentlink=(r"(https://bugs\.webkit\.org/show_bug\.cgi\?id=|webkit\.org/b/)(\d+)", r"https://bugs.webkit.org/show_bug.cgi?id=\2"),
authz=authz))

@@ -228,7 +228,7 @@ class CompileWebKit(shell.Compile):

def createSummary(self, log):
platform = self.getProperty('platform')
if platform.startswith('mac'):
if platform.startswith('mac'):
warnings = []
errors = []
sio = cStringIO.StringIO(log.getText())
@@ -298,10 +298,8 @@ class RunJavaScriptCoreTests(TestWithFailureCount):
name = "jscore-test"
description = ["jscore-tests running"]
descriptionDone = ["jscore-tests"]
_jsonFileName = "jsc_test_failures.json"
command = ["perl", "./Tools/Scripts/run-javascriptcore-tests", "--no-build", WithProperties("--%(configuration)s", "--json-output=%(_jsonFileName)s")]
command = ["perl", "./Tools/Scripts/run-javascriptcore-tests", "--no-build", WithProperties("--%(configuration)s")]
failedTestsFormatString = "%d JSC test%s failed"
logfiles = {"json": _jsonFileName}

def start(self):
appendCustomBuildFlags(self, self.getProperty('platform'), self.getProperty('fullPlatform'))
@@ -1,3 +1,17 @@
2016-04-25 Commit Queue <commit-queue@webkit.org>

Unreviewed, rolling out r199916.
https://bugs.webkit.org/show_bug.cgi?id=156989

Might break buildbot when master is restarted (Requested by
Srinivasan Vijayaraghava, Guest100, on #webkit).

Reverted changeset:

"Add JSC test results in json format to a buildbot log"
https://bugs.webkit.org/show_bug.cgi?id=156920
http://trac.webkit.org/changeset/199916

2016-04-23 Chris Dumez <cdumez@apple.com>

[WebIDL] Drop [Default] WebKit-IDL extended attribute
@@ -332,7 +332,8 @@ sub runJSCStressTests

if (defined($jsonFileName)) {
my %jsonData = (
"failures" => \@jscStressFailList,
"numJSCStressFailures" => $numJSCStressFailures,
"jscStressFailList" => \@jscStressFailList,
);

open(my $fileHandler, ">", $jsonFileName) or die;

0 comments on commit ec0b893

Please sign in to comment.